github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#3962] The H2 emulation of SHR might produce rounding errors

Browse Source
This commit is contained in:
lukaseder 2015-01-18 12:02:50 +01:00
parent 63e9522cb1
commit c21dfd2f31
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
jOOQ/src/main/java/org/jooq/impl/Expression.java
View File

@ -171,10 +171,13 @@ class Expression<T> extends AbstractFunction<T> {
// Many dialects don't support shifts. Use multiplication/division instead
else if (SHL == operator && asList(H2, HSQLDB).contains(family)) {
return lhs.mul(DSL.power(two(), rhsAsNumber()));
return lhs.mul((Field<? extends Number>) DSL.power(two(), rhsAsNumber()).cast(lhs));
}
// [#3962] This emulation is expensive. If this is emulated, BitCount should
// use division instead of SHR directly
else if (SHR == operator && asList(H2, HSQLDB).contains(family)) {
return lhs.div(DSL.power(two(), rhsAsNumber()));
return lhs.div((Field<? extends Number>) DSL.power(two(), rhsAsNumber()).cast(lhs));
}
// Some dialects support shifts as functions