From be64a88083296cb9da13c72a3e153a902916a2bc Mon Sep 17 00:00:00 2001 From: Knut Wannheden Date: Tue, 25 Jun 2019 08:41:46 +0200 Subject: [PATCH] [jOOQ/jOOQ#8754] Add a few missing parenthesis pairs While removing the SQL templating the parentheses went missing in some of the rendered SQL. Also added parenthesis pairs in a few cases where it might also have been missing before. --- jOOQ/src/main/java/org/jooq/impl/RegexpLike.java | 8 +++++--- jOOQ/src/main/java/org/jooq/impl/TableComparison.java | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/RegexpLike.java b/jOOQ/src/main/java/org/jooq/impl/RegexpLike.java index 53194e7295..270eaf9714 100644 --- a/jOOQ/src/main/java/org/jooq/impl/RegexpLike.java +++ b/jOOQ/src/main/java/org/jooq/impl/RegexpLike.java @@ -104,7 +104,7 @@ final class RegexpLike extends AbstractCondition { case POSTGRES: { - ctx.visit(search).sql(" ~ ").visit(pattern); + ctx.sql('(').visit(search).sql(" ~ ").visit(pattern).sql(')'); break; } @@ -130,11 +130,13 @@ final class RegexpLike extends AbstractCondition { case DERBY: case FIREBIRD: default: { - ctx.visit(search) + ctx.sql('(') + .visit(search) .sql(' ') .visit(K_LIKE_REGEX) .sql(' ') - .visit(pattern); + .visit(pattern) + .sql(')'); break; } diff --git a/jOOQ/src/main/java/org/jooq/impl/TableComparison.java b/jOOQ/src/main/java/org/jooq/impl/TableComparison.java index 5807fe6197..8fe9561037 100644 --- a/jOOQ/src/main/java/org/jooq/impl/TableComparison.java +++ b/jOOQ/src/main/java/org/jooq/impl/TableComparison.java @@ -71,7 +71,7 @@ final class TableComparison extends AbstractCondition { case POSTGRES: { - ctx.visit(lhs).sql(' ').sql(comparator.toSQL()).sql(' ').visit(rhs); + ctx.sql('(').visit(lhs).sql(' ').sql(comparator.toSQL()).sql(' ').visit(rhs).sql(')'); break; }