github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#2658] Inefficient emulation of row value expression comparison predicates <, <=, >, >=. Factor out predicates for improved index usage

Browse Source
This commit is contained in:
Lukas Eder 2013-10-23 17:37:00 +02:00
parent 4352c1849d
commit bd209424aa
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
jOOQ/src/main/java/org/jooq/impl/RowCondition.java
View File

@ -149,6 +149,14 @@ class RowCondition extends AbstractCondition {
: (comparator == LESS_OR_EQUAL) ? LESS
: null;
// [#2658] The factored order component of the comparator (enforcing the equal component)
Comparator factoredOrder
= (comparator == GREATER) ? GREATER_OR_EQUAL
: (comparator == GREATER_OR_EQUAL) ? GREATER_OR_EQUAL
: (comparator == LESS) ? LESS_OR_EQUAL
: (comparator == LESS_OR_EQUAL) ? LESS_OR_EQUAL
: null;
// Whether the comparator has an equal component
boolean equal
= (comparator == GREATER_OR_EQUAL)
@ -178,6 +186,17 @@ class RowCondition extends AbstractCondition {
}
Condition result = new CombinedCondition(Operator.OR, outer);
// [#2658] For performance reasons, an additional, redundant
// predicate is factored out to favour the application of range
// scans as the topmost predicate is AND-connected, not
// OR-connected:
// (A, B, C) > (X, Y, Z)
// (A >= X) AND ((A > X) OR (A = X AND B > Y) OR (A = X AND B = Y AND C > Z))
if (leftFields.length > 1) {
result = leftFields[0].compare(factoredOrder, (Field) rightFields[0]).and(result);
}
return (QueryPartInternal) result;
}
else {