github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#1060] Improve debug logging of H2 arrays. The syntax is not ARRAY[1, 2], but (1, 2)

Browse Source
This commit is contained in:
Lukas Eder 2012-01-11 19:02:59 +00:00
parent fe5bdc9749
commit b7a9db1c48
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
jOOQ/src/main/java/org/jooq/impl/Val.java
View File

@ -38,6 +38,7 @@ package org.jooq.impl;
import static java.util.Arrays.asList;
import static org.jooq.SQLDialect.DB2;
import static org.jooq.SQLDialect.DERBY;
import static org.jooq.SQLDialect.H2;
import static org.jooq.SQLDialect.HSQLDB;
import static org.jooq.SQLDialect.INGRES;
import static org.jooq.SQLDialect.POSTGRES;
@ -115,7 +116,7 @@ class Val<T> extends AbstractField<T> implements Param<T>, BindingProvider {
// [#722] TODO This is probably not entirely right.
case INGRES:
// [#1029] Postgres and [#632] Sybase need explicit casting
// [#1029] Postgres and [#632] Sybase need explicit casting
// in very rare cases.
case POSTGRES:
case SYBASE: {
@ -238,8 +239,17 @@ class Val<T> extends AbstractField<T> implements Param<T>, BindingProvider {
context.sql(val.toString());
}
else if (type.isArray()) {
context.sql("ARRAY")
.sql(Arrays.toString((Object[]) val));
// H2 renders arrays as tuples
if (context.getDialect() == H2) {
context.sql(Arrays.toString((Object[]) val).replaceAll("\\[([^]]*)\\]", "($1)"));
}
// By default, render HSQLDB / POSTGRES syntax
else {
context.sql("ARRAY")
.sql(Arrays.toString((Object[]) val));
}
}
else if (ArrayRecord.class.isAssignableFrom(type)) {
context.sql(val.toString());