github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#1010] The MERGE INTO .. WHEN NOT MATCHED THEN INSERT .. syntax may cause type-safety issues in some databases. VALUES should be converted before binding

Browse Source
This commit is contained in:
Lukas Eder 2012-01-04 21:13:16 +00:00
parent 5649a7a74b
commit b3f7dbb4a6
1 changed files with 41 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
jOOQ-test/src/org/jooq/test/jOOQAbstractTest.java
View File

@ -4492,6 +4492,7 @@ public abstract class jOOQAbstractTest<
reset = false;
// Always do an update of everything
// --------------------------------
create().mergeInto(TAuthor())
.using(create().selectOne())
.on("1 = 1")
@ -4507,6 +4508,7 @@ public abstract class jOOQAbstractTest<
.fetch(TAuthor_FIRST_NAME()));
// Always do an update of the first author
// --------------------------------
create().mergeInto(TAuthor())
.using(create().selectOne())
.on(TAuthor_ID().equal(1))
@ -4517,14 +4519,15 @@ public abstract class jOOQAbstractTest<
.execute();
assertEquals(Arrays.asList("John", "Alfred"),
create().selectFrom(TAuthor())
.orderBy(TAuthor_ID())
.fetch(TAuthor_FIRST_NAME()));
create().selectFrom(TAuthor())
.orderBy(TAuthor_ID())
.fetch(TAuthor_FIRST_NAME()));
Field<String> f = val("Dan").as("f");
Field<String> l = val("Brown").as("l");
// [#1000] Add a check for the alternative INSERT .. SET .. syntax
// --------------------------------
MergeFinalStep<A> q =
create().mergeInto(TAuthor())
.using(create().select(f, l))
@ -4536,18 +4539,53 @@ public abstract class jOOQAbstractTest<
.set(TAuthor_FIRST_NAME(), f)
.set(TAuthor_LAST_NAME(), l);
// Execute an insert
q.execute();
assertEquals(Arrays.asList("John", "Alfred", "Dan"),
create().selectFrom(TAuthor())
.orderBy(TAuthor_ID())
.fetch(TAuthor_FIRST_NAME()));
// Execute an update
q.execute();
assertEquals(Arrays.asList("John", "Alfred", "James"),
create().selectFrom(TAuthor())
.orderBy(TAuthor_ID())
.fetch(TAuthor_FIRST_NAME()));
f = val("Herman").as("f");
l = val("Hesse").as("l");
// Check if INSERT-only MERGE works
// --------------------------------
q =
create().mergeInto(TAuthor())
.using(create().select(f, l))
.on(TAuthor_LAST_NAME().equal(l))
.whenNotMatchedThenInsert(
TAuthor_ID(),
TAuthor_FIRST_NAME(),
TAuthor_LAST_NAME(),
TAuthor_DATE_OF_BIRTH())
// [#1010] Be sure that this type-unsafe clause can deal with
// any convertable type
.values("4", f, l, 0L);
// Execute an insert
q.execute();
assertEquals(Arrays.asList("John", "Alfred", "James", "Herman"),
create().selectFrom(TAuthor())
.orderBy(TAuthor_ID())
.fetch(TAuthor_FIRST_NAME()));
// Execute nothing
q.execute();
assertEquals(Arrays.asList("John", "Alfred", "James", "Herman"),
create().selectFrom(TAuthor())
.orderBy(TAuthor_ID())
.fetch(TAuthor_FIRST_NAME()));
// TODO: Add more sophisticated MERGE statement tests
// Especially for SQL Server and Sybase, some bugs could be expected
}