github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#15190] DISTINCT .. WITH TIES emulation renders too many DENSE_RANK() OVER (ORDER BY ...) clauses

Browse Source
This commit is contained in:
Lukas Eder 2023-06-07 18:05:09 +02:00
parent 6d94ccea9b
commit ac9aa44b09
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
View File

@ -2142,7 +2142,7 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
private final Field<Integer> limitWindowFunction(Context<?> c) {
return distinct
? DSL.denseRank().over(orderBy(getNonEmptyOrderByForDistinct(c.configuration())))
? DSL.denseRank().over(orderBy(getNonEmptyOrderBy(c.configuration())))
: getLimit().withTies()
? DSL.rank().over(orderBy(getNonEmptyOrderBy(c.configuration())))
: DSL.rowNumber().over(orderBy(getNonEmptyOrderBy(c.configuration())));
@ -4440,16 +4440,6 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
return getOrderBy();
}
final SortFieldList getNonEmptyOrderByForDistinct(Configuration configuration) {
SortFieldList order = new SortFieldList();
order.addAll(getNonEmptyOrderBy(configuration));
for (Field<?> field : getSelect())
order.add(field.asc());
return order;
}
@Override
public final void addOrderBy(Collection<? extends OrderField<?>> fields) {
getOrderBy().addAll(Tools.sortFields(fields));