From ac2764c8e0826e9e65066465be0be201a2144711 Mon Sep 17 00:00:00 2001 From: lukaseder Date: Thu, 5 Apr 2018 18:29:24 +0300 Subject: [PATCH] [#7392] Do not use HSQLDB's undocumented NULL keyword for the absence of NOT NULL constraints in CREATE TABLE --- jOOQ/src/main/java/org/jooq/impl/Tools.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/Tools.java b/jOOQ/src/main/java/org/jooq/impl/Tools.java index bfebd42863..4d5c7a2a30 100644 --- a/jOOQ/src/main/java/org/jooq/impl/Tools.java +++ b/jOOQ/src/main/java/org/jooq/impl/Tools.java @@ -638,7 +638,7 @@ final class Tools { private static final char[] HEX_DIGITS = "0123456789abcdef".toCharArray(); private static final EnumSet REQUIRES_BACKSLASH_ESCAPING = EnumSet.of(MARIADB, MYSQL); - private static final EnumSet NO_SUPPORT_NULL = EnumSet.of(DERBY, FIREBIRD); + private static final EnumSet NO_SUPPORT_NULL = EnumSet.of(DERBY, FIREBIRD, HSQLDB); private static final EnumSet NO_SUPPORT_BINARY_TYPE_LENGTH = EnumSet.of(POSTGRES); private static final EnumSet DEFAULT_BEFORE_NULL = EnumSet.of(FIREBIRD, HSQLDB); private static final EnumSet SUPPORT_MYSQL_SYNTAX = EnumSet.of(MARIADB, MYSQL); @@ -4049,7 +4049,7 @@ final class Tools { ctx.sql(' ').visit(K_NOT_NULL); // Some databases default to NOT NULL, so explicitly setting columns to NULL is mostly required here - // [#3400] [#4321] ... but not in Derby, Firebird + // [#3400] [#4321] [#7392] ... but not in Derby, Firebird, HSQLDB else if (!NO_SUPPORT_NULL.contains(ctx.family())) ctx.sql(' ').visit(K_NULL);