github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#3909] Inefficient number conversion in org.jooq.tools.Convert

Browse Source
This commit is contained in:
lukaseder 2015-01-09 08:56:57 +01:00
parent 8f72523997
commit a83ca073d1
1 changed files with 48 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
jOOQ/src/main/java/org/jooq/tools/Convert.java
View File

@ -488,6 +488,10 @@ public final class Convert {
// Various number types are converted between each other via String
else if (toClass == Byte.class || toClass == byte.class) {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) Byte.valueOf(((Number) from).byteValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? Byte.valueOf((byte) 1) : Byte.valueOf((byte) 0));
}
@ -500,6 +504,10 @@ public final class Convert {
}
}
else if (toClass == Short.class || toClass == short.class) {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) Short.valueOf(((Number) from).shortValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? Short.valueOf((short) 1) : Short.valueOf((short) 0));
}
@ -512,6 +520,10 @@ public final class Convert {
}
}
else if (toClass == Integer.class || toClass == int.class) {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) Integer.valueOf(((Number) from).intValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? Integer.valueOf(1) : Integer.valueOf(0));
}
@ -524,6 +536,10 @@ public final class Convert {
}
}
else if (toClass == Long.class || toClass == long.class) {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) Long.valueOf(((Number) from).longValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? Long.valueOf(1L) : Long.valueOf(0L));
}
@ -542,11 +558,15 @@ public final class Convert {
// ... this also includes unsigned number types
else if (toClass == UByte.class) {
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? ubyte(1) : ubyte(0));
}
try {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) ubyte(((Number) from).shortValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? ubyte(1) : ubyte(0));
}
return (U) ubyte(new BigDecimal(from.toString().trim()).shortValue());
}
catch (NumberFormatException e) {
@ -554,11 +574,15 @@ public final class Convert {
}
}
else if (toClass == UShort.class) {
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? ushort(1) : ushort(0));
}
try {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) ushort(((Number) from).intValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? ushort(1) : ushort(0));
}
return (U) ushort(new BigDecimal(from.toString().trim()).intValue());
}
catch (NumberFormatException e) {
@ -566,11 +590,15 @@ public final class Convert {
}
}
else if (toClass == UInteger.class) {
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? uint(1) : uint(0));
}
try {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) uint(((Number) from).longValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? uint(1) : uint(0));
}
return (U) uint(new BigDecimal(from.toString().trim()).longValue());
}
catch (NumberFormatException e) {
@ -596,6 +624,10 @@ public final class Convert {
// ... and floating point / fixed point types
else if (toClass == Float.class || toClass == float.class) {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) Float.valueOf(((Number) from).floatValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? Float.valueOf(1.0f) : Float.valueOf(0.0f));
}
@ -608,6 +640,10 @@ public final class Convert {
}
}
else if (toClass == Double.class || toClass == double.class) {
if (Number.class.isAssignableFrom(fromClass)) {
return (U) Double.valueOf(((Number) from).doubleValue());
}
if (fromClass == Boolean.class || fromClass == boolean.class) {
return (U) (((Boolean) from) ? Double.valueOf(1.0) : Double.valueOf(0.0));
}