github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#4321] Invalid SQL generated when using nullable data types for Derby

Browse Source
This commit is contained in:
lukaseder 2015-05-30 09:05:18 +02:00
parent 2980c11218
commit a762a767ef
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jOOQ/src/main/java/org/jooq/impl/CreateTableImpl.java
View File

@ -47,6 +47,7 @@ import static org.jooq.Clause.CREATE_TABLE_COLUMNS;
import static org.jooq.Clause.CREATE_TABLE_NAME;
// ...
// ...
import static org.jooq.SQLDialect.DERBY;
// ...
import static org.jooq.SQLDialect.POSTGRES;
// ...
@ -179,10 +180,15 @@ class CreateTableImpl<R extends Record> extends AbstractQuery implements
.sql(' ');
Utils.toSQLDDLTypeDeclaration(ctx, type);
if (type.nullable())
ctx.sql(' ').keyword("null");
else
if (type.nullable()) {
// [#4321] Not all dialects support explicit NULL type declarations
if (!asList(DERBY).contains(ctx.family()))
ctx.sql(' ').keyword("null");
}
else {
ctx.sql(' ').keyword("not null");
}
if (i < columnFields.size() - 1)
ctx.sql(',').formatSeparator();