github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#9134] Fix NTH_VALUE() [ FROM { FIRST | LAST } ] rendering

Browse Source 
The `NTH_VALUE() [ FROM { FIRST | LAST } ]` clause is rendered the same
for all dialects.
This commit is contained in:
Knut Wannheden 2019-09-03 09:04:08 +02:00
parent eaf48e48ef
commit a3f25af543
1 changed files with 27 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
jOOQ/src/main/java/org/jooq/impl/Function.java
View File

@ -594,51 +594,37 @@ class Function<T> extends AbstractField<T> implements
if (distinct)
if (args.size() > 1 && SUPPORT_DISTINCT_RVE.contains(ctx.family()))
ctx.sql(')');
if (ctx.family() != H2) {
if (TRUE.equals(fromLast))
ctx.sql(' ').visit(K_FROM).sql(' ').visit(K_LAST);
else if (FALSE.equals(fromLast))
ctx.sql(' ').visit(K_FROM).sql(' ').visit(K_FIRST);
if (TRUE.equals(ignoreNulls)) {
switch (ctx.family()) {
default:
ctx.sql(' ').visit(K_IGNORE_NULLS);
break;
}
}
else if (FALSE.equals(ignoreNulls)) {
switch (ctx.family()) {
default:
ctx.sql(' ').visit(K_RESPECT_NULLS);
break;
}
}
}
}
final void toSQLArguments2(Context<?> ctx) {
if (ctx.family() == H2) {
if (TRUE.equals(fromLast))
ctx.sql(' ').visit(K_FROM).sql(' ').visit(K_LAST);
else if (FALSE.equals(fromLast))
ctx.sql(' ').visit(K_FROM).sql(' ').visit(K_FIRST);
if (TRUE.equals(fromLast))
ctx.sql(' ').visit(K_FROM).sql(' ').visit(K_LAST);
else if (FALSE.equals(fromLast))
ctx.sql(' ').visit(K_FROM).sql(' ').visit(K_FIRST);
if (TRUE.equals(ignoreNulls))
ctx.sql(' ').visit(K_IGNORE_NULLS);
else if (FALSE.equals(ignoreNulls))
ctx.sql(' ').visit(K_RESPECT_NULLS);
if (TRUE.equals(ignoreNulls)) {
switch (ctx.family()) {
default:
ctx.sql(' ').visit(K_IGNORE_NULLS);
break;
}
}
else if (FALSE.equals(ignoreNulls)) {
switch (ctx.family()) {
default:
ctx.sql(' ').visit(K_RESPECT_NULLS);
break;
}
}
}