github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#4071] Emit a warning when a batch statement doesn't receive the right number of bind values

Browse Source
This commit is contained in:
Lukas Eder 2015-03-10 15:22:28 +01:00
parent c727033652
commit a30deb89b2
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
jOOQ/src/main/java/org/jooq/impl/BatchSingle.java
View File

@ -64,6 +64,7 @@ import org.jooq.Field;
import org.jooq.Param;
import org.jooq.Query;
import org.jooq.exception.ControlFlowSignal;
import org.jooq.tools.JooqLogger;
/**
* @author Lukas Eder
@ -74,24 +75,27 @@ class BatchSingle implements BatchBindStep {
* Generated UID
*/
private static final long serialVersionUID = 3793967258181493207L;
private static final JooqLogger log = JooqLogger.getLogger(BatchSingle.class);
private final DSLContext create;
private final Configuration configuration;
private final Query query;
private final Map<String, List<Integer>> nameToIndexMapping;
private final List<Object[]> allBindValues;
private final int expectedBindValues;
public BatchSingle(Configuration configuration, Query query) {
int i = 0;
ParamCollector collector = new ParamCollector(configuration, false);
collector.visit(query);
this.create = DSL.using(configuration);
this.configuration = configuration;
this.query = query;
this.allBindValues = new ArrayList<Object[]>();
this.nameToIndexMapping = new LinkedHashMap<String, List<Integer>>();
int i = 0;
ParamCollector collector = new ParamCollector(configuration, false);
collector.visit(query);
this.expectedBindValues = collector.resultList.size();
for (Entry<String, Param<?>> entry : collector.resultList) {
List<Integer> list = nameToIndexMapping.get(entry.getKey());
@ -155,6 +159,7 @@ class BatchSingle implements BatchBindStep {
@Override
public final int[] execute() {
checkBindValues();
// [#1180] Run batch queries with BatchMultiple, if no bind variables
// should be used...
@ -166,6 +171,12 @@ class BatchSingle implements BatchBindStep {
}
}
private final void checkBindValues() {
for (int i = 0; i < allBindValues.size(); i++)
if (allBindValues.get(i).length != expectedBindValues)
log.info("Bind value count", "Batch bind value set " + i + " has " + allBindValues.get(i).length + " values when " + expectedBindValues + " values were expected");
}
private final int[] executePrepared() {
ExecuteContext ctx = new DefaultExecuteContext(configuration, new Query[] { query });
ExecuteListener listener = new ExecuteListeners(ctx);