github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#8528] Interpret ALTER TABLE .. DROP PRIMARY KEY

Browse Source
This commit is contained in:
Lukas Eder 2019-10-15 14:12:46 +02:00
parent 138bef05a9
commit a2ae1fb187
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
jOOQ/src/main/java/org/jooq/impl/DDLInterpreter.java
View File

@ -38,6 +38,7 @@
package org.jooq.impl;
import static org.jooq.impl.AbstractName.NO_NAME;
import static org.jooq.impl.ConstraintType.PRIMARY_KEY;
import static org.jooq.impl.DSL.unquotedName;
import static org.jooq.impl.SQLDataType.BIGINT;
import static org.jooq.impl.Tools.EMPTY_FIELD;
@ -263,7 +264,8 @@ final class DDLInterpreter {
Table<?> renameTo = query.$renameTo();
Field<?> renameColumn = query.$renameColumn();
Field<?> renameColumnTo = query.$renameColumnTo();
List<Field<?>> $dropColumns = query.$dropColumns();
List<Field<?>> dropColumns = query.$dropColumns();
ConstraintType dropConstraintType = query.$dropConstraintType();
if (addColumn != null) {
if (query.$addFirst())
@ -307,16 +309,22 @@ final class DDLInterpreter {
else
existing.field(renameColumn).name = (UnqualifiedName) renameColumnTo.getUnqualifiedName();
}
else if ($dropColumns != null) {
else if (dropColumns != null) {
// TODO Implement cascade
// TODO check if any constraints or indexes reference this column.
List<MutableField> fields = existing.fields($dropColumns.toArray(EMPTY_FIELD), false);
List<MutableField> fields = existing.fields(dropColumns.toArray(EMPTY_FIELD), false);
if (fields.size() < $dropColumns.size() && !query.$ifExistsColumn())
existing.fields($dropColumns.toArray(EMPTY_FIELD), true);
if (fields.size() < dropColumns.size() && !query.$ifExistsColumn())
existing.fields(dropColumns.toArray(EMPTY_FIELD), true);
existing.fields.removeAll(fields);
}
else if (dropConstraintType == PRIMARY_KEY) {
if (existing.primaryKey != null)
existing.primaryKey = null;
else
throw primaryKeyNotExists();
}
else
throw unsupportedQuery(query);
}
@ -615,6 +623,10 @@ final class DDLInterpreter {
return new DataDefinitionException("Sequence already exists: " + sequence.getQualifiedName());
}
private static final DataDefinitionException primaryKeyNotExists() {
return new DataDefinitionException("Primary key does not exist");
}
private static final DataDefinitionException indexNotExists(Index index) {
return new DataDefinitionException("Index does not exist: " + index.getQualifiedName());
}