github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#12951] GenerationTool should handle HSQLDB driver returning

Browse Source 
null Connection on Driver::connect
This commit is contained in:
Lukas Eder 2022-01-26 10:16:20 +01:00
parent 5dd3e641c8
commit a18294daf4
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jOOQ-codegen/src/main/java/org/jooq/codegen/GenerationTool.java
View File

@ -365,7 +365,13 @@ public class GenerationTool {
if (!properties.containsKey("password"))
properties.put("password", defaultString(j.getPassword()));
setConnection(driver.newInstance().connect(defaultString(j.getUrl()), properties));
Connection c = driver.newInstance().connect(defaultString(j.getUrl()), properties);
// [#12951] Some drivers may (illegally) return null if the URL is incorrect?
if (c == null)
throw new SQLException("Cannot connect to database using JDBC URL: " + j.getUrl() + ". Please review your JDBC configuration in the code generator configuration.");
setConnection(c);
if (j.getInitScript() != null)
for (String sql : j.getInitScript().split(defaultIfBlank(j.getInitSeparator(), ";")))