github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#15732] COUNT(DISTINCT a, b) should be COUNT(DISTINCT (a, b))

Browse Source
This commit is contained in:
Lukas Eder 2024-03-26 13:15:59 +01:00
parent 5923613f1d
commit 9d9a2e2415
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
jOOQ/src/main/java/org/jooq/impl/AbstractAggregateFunction.java
View File

@ -114,7 +114,7 @@ implements
static final Set<SQLDialect> NO_SUPPORT_FILTER = SQLDialect.supportedUntil(CUBRID, DERBY, IGNITE, MARIADB, MYSQL);
static final Set<SQLDialect> NO_SUPPORT_WINDOW_FILTER = SQLDialect.supportedBy(TRINO);
static final Set<SQLDialect> SUPPORT_DISTINCT_RVE = SQLDialect.supportedBy(H2, POSTGRES);
static final Set<SQLDialect> REQUIRE_DISTINCT_RVE = SQLDialect.supportedBy(DUCKDB, H2, POSTGRES);
static final Lazy<Field<Integer>> ASTERISK = Lazy.of(() -> DSL.field(DSL.raw("*"), Integer.class));
@ -268,7 +268,7 @@ implements
// [#2883][#9109] PostgreSQL and H2 can use the DISTINCT keyword with formal row value expressions.
// [#13415] ListAgg is a special case, where the second argument is the separator
if (parens |= (args.size() > 1 && SUPPORT_DISTINCT_RVE.contains(ctx.dialect()) && !(this instanceof ListAgg)))
if (parens |= (args.size() > 1 && REQUIRE_DISTINCT_RVE.contains(ctx.dialect()) && !(this instanceof ListAgg)))
ctx.sql('(');
}