From 9cd9867f89696cadae9fa8a1235f50c6826c2ae7 Mon Sep 17 00:00:00 2001 From: lukaseder Date: Thu, 20 Aug 2015 11:54:01 +0200 Subject: [PATCH] [#4481] Added a comment explaining the rationale --- jOOQ/src/main/java/org/jooq/impl/DateDiff.java | 3 +++ jOOQ/src/main/java/org/jooq/impl/TimestampDiff.java | 3 +++ 2 files changed, 6 insertions(+) diff --git a/jOOQ/src/main/java/org/jooq/impl/DateDiff.java b/jOOQ/src/main/java/org/jooq/impl/DateDiff.java index d076bf4b1e..8ef93a03a1 100644 --- a/jOOQ/src/main/java/org/jooq/impl/DateDiff.java +++ b/jOOQ/src/main/java/org/jooq/impl/DateDiff.java @@ -96,6 +96,9 @@ class DateDiff extends AbstractFunction { xx [/pro] */ case CUBRID: case POSTGRES: + + // [#4481] Parentheses are important in case this expression is + // placed in the context of other arithmetic return field("({0} - {1})", getDataType(), date1, date2); /* [pro] xx diff --git a/jOOQ/src/main/java/org/jooq/impl/TimestampDiff.java b/jOOQ/src/main/java/org/jooq/impl/TimestampDiff.java index 0ebe00f372..c5ab4cf5ae 100644 --- a/jOOQ/src/main/java/org/jooq/impl/TimestampDiff.java +++ b/jOOQ/src/main/java/org/jooq/impl/TimestampDiff.java @@ -106,6 +106,9 @@ class TimestampDiff extends AbstractFunction { xxxx xxxxxxx xx [/pro] */ case POSTGRES: + + // [#4481] Parentheses are important in case this expression is + // placed in the context of other arithmetic return field("({0} - {1})", getDataType(), timestamp1, timestamp2); // CUBRID's datetime operations operate on a millisecond level