From 9aec5c9de7fe693d45624bd2153a9df6a6f9aa13 Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Mon, 12 Aug 2024 08:37:45 +0200 Subject: [PATCH] [jOOQ/jOOQ#17040] SQLDialect.JAVA warning message about derived tables not being supported is misleading --- .../main/java/org/jooq/impl/CommonTableExpressionImpl.java | 7 +++++++ jOOQ/src/main/java/org/jooq/impl/DerivedTable.java | 6 ++++++ jOOQ/src/main/java/org/jooq/impl/WindowDefinitionImpl.java | 5 +++++ 3 files changed, 18 insertions(+) diff --git a/jOOQ/src/main/java/org/jooq/impl/CommonTableExpressionImpl.java b/jOOQ/src/main/java/org/jooq/impl/CommonTableExpressionImpl.java index 24e6c51e05..5bac360ef4 100644 --- a/jOOQ/src/main/java/org/jooq/impl/CommonTableExpressionImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/CommonTableExpressionImpl.java @@ -122,6 +122,13 @@ final class CommonTableExpressionImpl extends AbstractTable + + + + + + + if (ctx.declareCTE()) { QueryPart s = query; diff --git a/jOOQ/src/main/java/org/jooq/impl/DerivedTable.java b/jOOQ/src/main/java/org/jooq/impl/DerivedTable.java index 6e4871be38..af443923ba 100644 --- a/jOOQ/src/main/java/org/jooq/impl/DerivedTable.java +++ b/jOOQ/src/main/java/org/jooq/impl/DerivedTable.java @@ -110,6 +110,12 @@ class DerivedTable extends AbstractTable implements QOM.Der + + + + + + visitSubquery(ctx, query(), DERIVED_TABLE, false); } diff --git a/jOOQ/src/main/java/org/jooq/impl/WindowDefinitionImpl.java b/jOOQ/src/main/java/org/jooq/impl/WindowDefinitionImpl.java index addfc46d1e..9bee8dfdf3 100644 --- a/jOOQ/src/main/java/org/jooq/impl/WindowDefinitionImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/WindowDefinitionImpl.java @@ -90,6 +90,11 @@ final class WindowDefinitionImpl extends AbstractQueryPart implements WindowDefi + + + + + // In the WINDOW clause, always declare window definitions if (ctx.declareWindows()) { ctx.visit(name)