[jOOQ/jOOQ#9017] Rename setting to transformRownum

This commit is contained in:
Lukas Eder 2020-09-24 09:54:23 +02:00
parent c3f8c3028e
commit 87ab89ba7c
3 changed files with 23 additions and 18 deletions

View File

@ -95,7 +95,7 @@ public class Settings
@XmlElement(defaultValue = "false")
protected Boolean transformTableListsToAnsiJoin = false;
@XmlElement(defaultValue = "false")
protected Boolean transformRownumToLimit = false;
protected Boolean transformRownum = false;
@XmlElement(defaultValue = "NEVER")
@XmlSchemaType(name = "string")
protected TransformUnneededArithmeticExpressions transformUnneededArithmeticExpressions = TransformUnneededArithmeticExpressions.NEVER;
@ -853,8 +853,9 @@ public class Settings
* Transform <code>ROWNUM</code> expressions to corresponding <code>LIMIT</code> clauses or <code>ROW_NUMBER()</code> expressions.
* <p>
* In Oracle 11g and less, <code>ROWNUM</code> filtering was the most popular way to paginate. This pseudo
* column is not supported in other RDBMS, and should be replaced in Oracle 12c by the FETCH clause. This
* transformation allows for replacing such a filter by equivalent SQL, if possible.
* column is not supported in other RDBMS, and should be replaced in Oracle 12c by the FETCH clause or
* <code>ROW_NUMBER() OVER ()</code> filtering. This transformation allows for replacing such a filter by
* equivalent SQL, if possible.
* <p>
* This feature is available in the commercial distribution only.
*
@ -863,20 +864,20 @@ public class Settings
* {@link Boolean }
*
*/
public Boolean isTransformRownumToLimit() {
return transformRownumToLimit;
public Boolean isTransformRownum() {
return transformRownum;
}
/**
* Sets the value of the transformRownumToLimit property.
* Sets the value of the transformRownum property.
*
* @param value
* allowed object is
* {@link Boolean }
*
*/
public void setTransformRownumToLimit(Boolean value) {
this.transformRownumToLimit = value;
public void setTransformRownum(Boolean value) {
this.transformRownum = value;
}
/**
@ -2464,8 +2465,8 @@ public class Settings
return this;
}
public Settings withTransformRownumToLimit(Boolean value) {
setTransformRownumToLimit(value);
public Settings withTransformRownum(Boolean value) {
setTransformRownum(value);
return this;
}
@ -3055,7 +3056,7 @@ public class Settings
builder.append("fetchTriggerValuesAfterSQLServerOutput", fetchTriggerValuesAfterSQLServerOutput);
builder.append("transformAnsiJoinToTableLists", transformAnsiJoinToTableLists);
builder.append("transformTableListsToAnsiJoin", transformTableListsToAnsiJoin);
builder.append("transformRownumToLimit", transformRownumToLimit);
builder.append("transformRownum", transformRownum);
builder.append("transformUnneededArithmeticExpressions", transformUnneededArithmeticExpressions);
builder.append("backslashEscaping", backslashEscaping);
builder.append("paramType", paramType);
@ -3362,12 +3363,12 @@ public class Settings
return false;
}
}
if (transformRownumToLimit == null) {
if (other.transformRownumToLimit!= null) {
if (transformRownum == null) {
if (other.transformRownum!= null) {
return false;
}
} else {
if (!transformRownumToLimit.equals(other.transformRownumToLimit)) {
if (!transformRownum.equals(other.transformRownum)) {
return false;
}
}
@ -4023,7 +4024,7 @@ public class Settings
result = ((prime*result)+((fetchTriggerValuesAfterSQLServerOutput == null)? 0 :fetchTriggerValuesAfterSQLServerOutput.hashCode()));
result = ((prime*result)+((transformAnsiJoinToTableLists == null)? 0 :transformAnsiJoinToTableLists.hashCode()));
result = ((prime*result)+((transformTableListsToAnsiJoin == null)? 0 :transformTableListsToAnsiJoin.hashCode()));
result = ((prime*result)+((transformRownumToLimit == null)? 0 :transformRownumToLimit.hashCode()));
result = ((prime*result)+((transformRownum == null)? 0 :transformRownum.hashCode()));
result = ((prime*result)+((transformUnneededArithmeticExpressions == null)? 0 :transformUnneededArithmeticExpressions.hashCode()));
result = ((prime*result)+((backslashEscaping == null)? 0 :backslashEscaping.hashCode()));
result = ((prime*result)+((paramType == null)? 0 :paramType.hashCode()));

View File

@ -20247,6 +20247,9 @@ public class DSL {

View File

@ -216,12 +216,13 @@ this flag enables the transformation to ANSI join syntax.
This feature is available in the commercial distribution only.]]></jxb:javadoc></jxb:property></appinfo></annotation>
</element>
<element name="transformRownumToLimit" type="boolean" minOccurs="0" maxOccurs="1" default="false">
<element name="transformRownum" type="boolean" minOccurs="0" maxOccurs="1" default="false">
<annotation><appinfo><jxb:property><jxb:javadoc><![CDATA[Transform <code>ROWNUM</code> expressions to corresponding <code>LIMIT</code> clauses or <code>ROW_NUMBER()</code> expressions.
<p>
In Oracle 11g and less, <code>ROWNUM</code> filtering was the most popular way to paginate. This pseudo
column is not supported in other RDBMS, and should be replaced in Oracle 12c by the FETCH clause. This
transformation allows for replacing such a filter by equivalent SQL, if possible.
column is not supported in other RDBMS, and should be replaced in Oracle 12c by the FETCH clause or
<code>ROW_NUMBER() OVER ()</code> filtering. This transformation allows for replacing such a filter by
equivalent SQL, if possible.
<p>
This feature is available in the commercial distribution only.]]></jxb:javadoc></jxb:property></appinfo></annotation>
</element>