github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#6666] Costly null check in CombinedCondition constructor

Browse Source
This commit is contained in:
lukaseder 2017-10-10 12:36:01 +02:00
parent e838574946
commit 82c2cc04db
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java
View File

@ -69,11 +69,6 @@ final class CombinedCondition extends AbstractCondition {
CombinedCondition(Operator operator, Collection<? extends Condition> conditions) {
if (operator == null)
throw new IllegalArgumentException("The argument 'operator' must not be null");
if (conditions == null)
throw new IllegalArgumentException("The argument 'conditions' must not be null");
for (Condition condition : conditions)
if (condition == null)
throw new IllegalArgumentException("The argument 'conditions' must not contain null");
this.operator = operator;
this.conditions = new ArrayList<Condition>(conditions.size());
@ -91,9 +86,10 @@ final class CombinedCondition extends AbstractCondition {
else
this.conditions.add(condition);
}
else {
else if (condition == null)
throw new IllegalArgumentException("The argument 'conditions' must not contain null");
else
this.conditions.add(condition);
}
}
}