From 7f9ce2adf908950c1f855d86cd66c7b26700e8cd Mon Sep 17 00:00:00 2001
From: Lukas Eder <lukas.eder@gmail.com>
Date: Fri, 6 Apr 2012 15:51:19 +0000
Subject: [PATCH] [#1274] Add support for the Oracle LISTAGG() analytic
 function - fixed regression

---
 .../java/org/jooq/impl/WindowFunction.java     | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/jOOQ/src/main/java/org/jooq/impl/WindowFunction.java b/jOOQ/src/main/java/org/jooq/impl/WindowFunction.java
index 3cc530c905..d90921a5da 100644
--- a/jOOQ/src/main/java/org/jooq/impl/WindowFunction.java
+++ b/jOOQ/src/main/java/org/jooq/impl/WindowFunction.java
@@ -151,26 +151,31 @@ implements
         }
 
         context.sql(")");
-
         if (!withinGroupOrderBy.isEmpty()) {
             context.keyword(" within group (order by ")
                    .sql(withinGroupOrderBy)
                    .sql(")");
         }
 
+        String glue = "";
         context.keyword(" over (");
         if (!partitionBy.isEmpty()) {
             if (partitionByOne && context.getDialect() == SQLDialect.SYBASE) {
                 // Ignore partition clause. Sybase does not support this construct
             }
             else {
-                context.keyword("partition by ")
+                context.sql(glue)
+                       .keyword("partition by ")
                        .sql(partitionBy);
+
+                glue = " ";
             }
         }
 
         if (!orderBy.isEmpty()) {
-            context.keyword("order by ");
+            context.sql(glue)
+            	   .keyword("order by ");
+
             switch (context.getDialect()) {
 
                 // SQL Server and Sybase don't allow for fully qualified fields
@@ -190,21 +195,26 @@ implements
                     break;
                 }
             }
+
+            glue = " ";
         }
 
         if (rowsStart != null) {
+            context.sql(glue);
             context.keyword("rows ");
 
             if (rowsEnd != null) {
                 context.keyword("between ");
                 toSQLRows(context, rowsStart);
 
-                context.keyword("and ");
+                context.keyword(" and ");
                 toSQLRows(context, rowsEnd);
             }
             else {
                 toSQLRows(context, rowsStart);
             }
+
+            glue = " ";
         }
 
         context.sql(")");