github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#18261] Failed UpdateableRecord::delete resets the Record::original values to null and sets the Record::touched values to true

Browse Source
This commit is contained in:
Lukas Eder 2025-04-02 14:15:09 +02:00
parent 34147ba9f6
commit 7d0887a1e0
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
jOOQ/src/main/java/org/jooq/impl/UpdatableRecordImpl.java
View File

@ -86,6 +86,7 @@ import org.jooq.TableRecord;
import org.jooq.UniqueKey;
import org.jooq.UpdatableRecord;
import org.jooq.conf.UpdateUnchangedRecords;
import org.jooq.exception.ControlFlowSignal;
import org.jooq.exception.DataChangedException;
import org.jooq.exception.NoDataFoundException;
import org.jooq.impl.BatchCRUD.QueryCollectorSignal;
@ -407,6 +408,7 @@ implements
private final int delete0() {
TableField<R, ?>[] keys = getPrimaryKey().getFieldsArray();
Throwable t = null;
try {
DeleteQuery<R> delete1 = create().deleteQuery(getTable());
@ -429,12 +431,21 @@ implements
return result;
}
catch (Throwable t0) {
t = t0;
throw t0;
}
// [#673] [#3363] If store() is called after delete(), a new INSERT should
// be executed and the record should be recreated
finally {
touched(true);
asList(originals).replaceAll(e -> null);
fetched = false;
// [#18261] These state changes must happen only on successful deletion
if (t == null || t instanceof ControlFlowSignal) {
touched(true);
asList(originals).replaceAll(e -> null);
fetched = false;
}
}
}