From 7c9177ea8640e360787bd9d001d2c3da5a75dfaf Mon Sep 17 00:00:00 2001
From: Lukas Eder <lukas.eder@gmail.com>
Date: Mon, 4 Aug 2014 17:26:57 +0200
Subject: [PATCH] [#3496] Log a DEBUG message when a Query is executed which
 returns Query.isExecutable() == false

---
 jOOQ/src/main/java/org/jooq/impl/AbstractQuery.java |  3 +--
 .../main/java/org/jooq/impl/TableRecordImpl.java    | 13 ++++++++++---
 .../java/org/jooq/impl/UpdatableRecordImpl.java     | 11 +++++++++--
 3 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/jOOQ/src/main/java/org/jooq/impl/AbstractQuery.java b/jOOQ/src/main/java/org/jooq/impl/AbstractQuery.java
index 843a5afa35..2c0172ae15 100644
--- a/jOOQ/src/main/java/org/jooq/impl/AbstractQuery.java
+++ b/jOOQ/src/main/java/org/jooq/impl/AbstractQuery.java
@@ -355,9 +355,8 @@ abstract class AbstractQuery extends AbstractQueryPart implements Query, Attacha
             }
         }
         else {
-            if (log.isDebugEnabled()) {
+            if (log.isDebugEnabled())
                 log.debug("Query is not executable", this);
-            }
 
             return 0;
         }
diff --git a/jOOQ/src/main/java/org/jooq/impl/TableRecordImpl.java b/jOOQ/src/main/java/org/jooq/impl/TableRecordImpl.java
index 311d5f0a60..7e4b818469 100644
--- a/jOOQ/src/main/java/org/jooq/impl/TableRecordImpl.java
+++ b/jOOQ/src/main/java/org/jooq/impl/TableRecordImpl.java
@@ -62,6 +62,7 @@ import org.jooq.Table;
 import org.jooq.TableField;
 import org.jooq.TableRecord;
 import org.jooq.UpdatableRecord;
+import org.jooq.tools.JooqLogger;
 
 /**
  * A record implementation for a record originating from a single table
@@ -75,8 +76,9 @@ public class TableRecordImpl<R extends TableRecord<R>> extends AbstractRecord im
     /**
      * Generated UID
      */
-    private static final long serialVersionUID = 3216746611562261641L;
-    private final Table<R>    table;
+    private static final long       serialVersionUID = 3216746611562261641L;
+    private static final JooqLogger log              = JooqLogger.getLogger(TableRecordImpl.class);
+    private final Table<R>          table;
 
     public TableRecordImpl(Table<R> table) {
         super(table.fields());
@@ -150,7 +152,12 @@ public class TableRecordImpl<R extends TableRecord<R>> extends AbstractRecord im
         addChangedValues(storeFields, insert);
 
         // Don't store records if no value was set by client code
-        if (!insert.isExecutable()) return 0;
+        if (!insert.isExecutable()) {
+            if (log.isDebugEnabled())
+                log.debug("Query is not executable", this);
+
+            return 0;
+        }
 
         // [#1596] Set timestamp and/or version columns to appropriate values
         BigInteger version = addRecordVersion(insert);
diff --git a/jOOQ/src/main/java/org/jooq/impl/UpdatableRecordImpl.java b/jOOQ/src/main/java/org/jooq/impl/UpdatableRecordImpl.java
index 2cb3ce7be1..0f067e3c70 100644
--- a/jOOQ/src/main/java/org/jooq/impl/UpdatableRecordImpl.java
+++ b/jOOQ/src/main/java/org/jooq/impl/UpdatableRecordImpl.java
@@ -72,6 +72,7 @@ import org.jooq.UpdateQuery;
 import org.jooq.exception.DataAccessException;
 import org.jooq.exception.DataChangedException;
 import org.jooq.exception.InvalidResultException;
+import org.jooq.tools.JooqLogger;
 import org.jooq.tools.StringUtils;
 
 /**
@@ -86,7 +87,8 @@ public class UpdatableRecordImpl<R extends UpdatableRecord<R>> extends TableReco
     /**
      * Generated UID
      */
-    private static final long serialVersionUID      = -1012420583600561579L;
+    private static final long       serialVersionUID = -1012420583600561579L;
+    private static final JooqLogger log              = JooqLogger.getLogger(UpdatableRecordImpl.class);
 
     public UpdatableRecordImpl(Table<R> table) {
         super(table);
@@ -209,7 +211,12 @@ public class UpdatableRecordImpl<R extends UpdatableRecord<R>> extends TableReco
         Utils.addConditions(update, this, keys);
 
         // Don't store records if no value was set by client code
-        if (!update.isExecutable()) return 0;
+        if (!update.isExecutable()) {
+            if (log.isDebugEnabled())
+                log.debug("Query is not executable", this);
+
+            return 0;
+        }
 
         // [#1596] Set timestamp and/or version columns to appropriate values
         BigInteger version = addRecordVersion(update);