github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#14191] DefaultDiagnosticsContext should cache resultSetFetchedRows

Browse Source
This commit is contained in:
Lukas Eder 2022-11-09 11:35:12 +01:00
parent aad8dd8fae
commit 7c6ab54867
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
jOOQ/src/main/java/org/jooq/impl/DefaultDiagnosticsContext.java
View File

@ -71,6 +71,7 @@ final class DefaultDiagnosticsContext extends AbstractScope implements Diagnosti
int resultSetFetchedColumnCount;
int resultSetConsumedColumnCount;
int resultSetFetchedRows;
boolean resultSetFetchedRowsComputed;
int resultSetConsumedRows;
final String actualStatement;
final String normalisedStatement;
@ -152,15 +153,21 @@ final class DefaultDiagnosticsContext extends AbstractScope implements Diagnosti
if (resultSet == null)
return -1;
try {
if (resultSetClosing || resultSet.getType() != ResultSet.TYPE_FORWARD_ONLY) {
while (resultSet.next())
resultSetFetchedRows++;
// [#14191] Compute this value only once, in order to produce the same
// value for all DiagnosticsListeners
if (!resultSetFetchedRowsComputed) {
resultSetFetchedRowsComputed = true;
resultSet.absolute(resultSetConsumedRows);
try {
if (resultSetClosing || resultSet.getType() != ResultSet.TYPE_FORWARD_ONLY) {
while (resultSet.next())
resultSetFetchedRows++;
resultSet.absolute(resultSetConsumedRows);
}
}
catch (SQLException ignore) {}
}
catch (SQLException ignore) {}
return resultSetFetchedRows;
}