github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#3982] Empty, OR-connected CombinedConditions should return FALSE, not TRUE

Browse Source
This commit is contained in:
lukaseder 2015-01-26 14:54:32 +01:00
parent eaf909ac33
commit 7b17735cc0
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java
View File

@ -45,6 +45,7 @@ import static org.jooq.Clause.CONDITION;
import static org.jooq.Clause.CONDITION_AND;
import static org.jooq.Clause.CONDITION_OR;
import static org.jooq.Operator.AND;
import static org.jooq.impl.DSL.falseCondition;
import static org.jooq.impl.DSL.trueCondition;
import java.util.ArrayList;
@ -112,7 +113,10 @@ class CombinedCondition extends AbstractCondition {
@Override
public final void accept(Context<?> ctx) {
if (conditions.isEmpty()) {
ctx.visit(trueCondition());
if (operator == AND)
ctx.visit(trueCondition());
else
ctx.visit(falseCondition());
}
else if (conditions.size() == 1) {
ctx.visit(conditions.get(0));