From 700d88bb08182b64d85ff8f4e337af99ddffe0ca Mon Sep 17 00:00:00 2001
From: Lukas Eder <lukas.eder@gmail.com>
Date: Thu, 1 Mar 2012 16:32:48 +0000
Subject: [PATCH] [#1199] Table.getFields() returns an internal representation
 of a table's field list. Make generated tables immutable instead!

---
 jOOQ/src/main/java/org/jooq/UpdatableTable.java    | 6 ++++--
 jOOQ/src/main/java/org/jooq/impl/AbstractType.java | 3 ++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/jOOQ/src/main/java/org/jooq/UpdatableTable.java b/jOOQ/src/main/java/org/jooq/UpdatableTable.java
index 86425b4c3b..aef71ac0a8 100644
--- a/jOOQ/src/main/java/org/jooq/UpdatableTable.java
+++ b/jOOQ/src/main/java/org/jooq/UpdatableTable.java
@@ -62,7 +62,8 @@ public interface UpdatableTable<R extends Record> extends Updatable<R>, Table<R>
      * Retrieve all of the table's unique keys.
      *
      * @return All keys. This is never <code>null</code> or empty, because
-     *         {@link UpdatableTable}'s always have at least one key.
+     *         {@link UpdatableTable}'s always have at least one key. This
+     *         method returns an unmodifiable list.
      */
     List<UniqueKey<R>> getKeys();
 
@@ -73,7 +74,8 @@ public interface UpdatableTable<R extends Record> extends Updatable<R>, Table<R>
      * @param <O> The other table's record type
      * @param other The other table of the foreign key relationship
      * @return Some other table's <code>FOREIGN KEY</code>'s towards an this
-     *         table. This is never <code>null</code>.
+     *         table. This is never <code>null</code>. This method returns an
+     *         unmodifiable list.
      */
     <O extends Record> List<ForeignKey<O, R>> getReferencesFrom(Table<O> other);
 
diff --git a/jOOQ/src/main/java/org/jooq/impl/AbstractType.java b/jOOQ/src/main/java/org/jooq/impl/AbstractType.java
index b04831071b..940fe28de6 100644
--- a/jOOQ/src/main/java/org/jooq/impl/AbstractType.java
+++ b/jOOQ/src/main/java/org/jooq/impl/AbstractType.java
@@ -35,6 +35,7 @@
  */
 package org.jooq.impl;
 
+import java.util.Collections;
 import java.util.List;
 
 import org.jooq.AliasProvider;
@@ -60,7 +61,7 @@ abstract class AbstractType<R extends Record> extends AbstractSchemaProviderQuer
 
     @Override
     public final List<Field<?>> getFields() {
-        return getFieldList();
+        return Collections.unmodifiableList(getFieldList());
     }
 
     @Override