github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#17803] Double or Float inline values should be cast to their

Browse Source 
appropriate types where the rendered literals are interpreted as NUMERIC
or DECIMAL
This commit is contained in:
Lukas Eder 2025-01-07 16:34:38 +01:00
parent 32f8669d2d
commit 662243d51b
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
jOOQ/src/main/java/org/jooq/impl/DefaultBinding.java
View File

@ -816,6 +816,26 @@ public class DefaultBinding<T, U> implements Binding<T, U> {
return true;
}
}
// [#17803] Some dialects require the cast for syntactic reasons (see DefaultDoubleBinding.REQUIRES_LITERAL_CAST)
// Others require it occasionally to prevent wrong type promotions, on literals only.
if (dataType.isFloat()) {
switch (ctx.family()) {
case FIREBIRD:
// [#10879] We'll need more precise cast types, first!
// case MARIADB:
// case MYSQL:
case POSTGRES:
case YUGABYTEDB:
return true;
}
}
}
// Many dialects require casts for bind values
@ -1038,6 +1058,7 @@ public class DefaultBinding<T, U> implements Binding<T, U> {
// [#7351] UUID data types need to be cast too
// [#7242] JSON(B) data types need to be cast too
// [#13252] XML data types need to be cast too
// [#17803] Floating point literals need to be cast as well
else if (REQUIRES_JSON_CAST.contains(ctx.dialect()) &&
(sqlDataType == null ||
(!sqlDataType.isTemporal()
@ -1046,7 +1067,8 @@ public class DefaultBinding<T, U> implements Binding<T, U> {
&& !sqlDataType.isJSON())))
&& !sqlDataType.isJSON())
&& !sqlDataType.isFloat()))
sql(ctx, converted);