github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#582] Simulate JOIN USING syntax, where this is unavailable

Browse Source
This commit is contained in:
Lukas Eder 2012-01-17 19:31:05 +00:00
parent 0ba28f37da
commit 63dcbd56a4
2 changed files with 30 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jOOQ-test/src/org/jooq/test/jOOQAbstractTest.java
View File

@ -5850,18 +5850,6 @@ public abstract class jOOQAbstractTest<
@Test
public void testJoinUsing() throws Exception {
// TODO [#582] Simulate this
switch (getDialect()) {
case ASE:
case DB2:
case H2:
case SQLSERVER:
case SYBASE:
log.info("SKIPPING", "JOIN USING tests");
return;
}
Result<Record> result =
create().select(TAuthor_LAST_NAME(), TBook_TITLE())
.from(TAuthor())

33
jOOQ/src/main/java/org/jooq/impl/JoinTable.java
View File

@ -151,9 +151,36 @@ class JoinTable extends AbstractTable<Record> implements TableOnStep, TableOnCon
private void toSQLJoinCondition(RenderContext context) {
if (!using.isEmpty()) {
context.sql(" using (");
Util.toSQLNames(context, using);
context.sql(")");
switch (context.getDialect()) {
// [#582] Some dialects don't explicitly support a JOIN .. USING
// syntax. This can be simulated with JOIN .. ON
case ASE:
case DB2:
case H2:
case SQLSERVER:
case SYBASE: {
context.sql(" on ");
String glue = "";
for (Field<?> field : using) {
context.sql(glue)
.sql(lhs.getField(field))
.sql(" = ")
.sql(rhs.getField(field));
glue = " and ";
}
break;
}
default: {
context.sql(" using (");
Util.toSQLNames(context, using);
context.sql(")");
}
}
}
else {
context.sql(" on ").sql(condition);