github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#14331] Add Settings.renderRedundantConditionForSeekClause to improve SEEK predicate performance in some RDBMS

Browse Source
This commit is contained in:
Lukas Eder 2022-12-01 10:01:14 +01:00
parent d445b361eb
commit 625e2171f1
3 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
jOOQ/src/main/java/org/jooq/conf/Settings.java
View File

@ -107,6 +107,8 @@ public class Settings
protected Boolean renderVariablesInDerivedTablesForEmulations = true;
@XmlElement(defaultValue = "true")
protected Boolean renderRowConditionForSeekClause = true;
@XmlElement(defaultValue = "false")
protected Boolean renderRedundantConditionForSeekClause = false;
@XmlElement(defaultValue = ".")
protected String namePathSeparator = ".";
@XmlElement(defaultValue = "false")
@ -1180,6 +1182,33 @@ public class Settings
this.renderRowConditionForSeekClause = value;
}
/**
* Whether a redundant <code>(a <= :a)</code> predicate should be rendered for a <code>(a, b) < (:a, :b)</code> predicate for the <code>SEEK</code> clause.
* <p>
* Some RDBMS may not be able to properly optimise <code>(a, b) < ('a', 'b')</code> or <code>(a < 'a') OR (a = 'a' AND b < 'b')</code>, and choose an appropriate index. By adding an additional redundant predicate,
* jOOQ may help the optimiser, e.g. <code>(a <= :a) AND (a, b) < ('a', 'b')</code> or <code>(a <= :a) AND ((a < 'a') OR (a = 'a' AND b < 'b'))</code>
*
* @return
* possible object is
* {@link Boolean }
*
*/
public Boolean isRenderRedundantConditionForSeekClause() {
return renderRedundantConditionForSeekClause;
}
/**
* Sets the value of the renderRedundantConditionForSeekClause property.
*
* @param value
* allowed object is
* {@link Boolean }
*
*/
public void setRenderRedundantConditionForSeekClause(Boolean value) {
this.renderRedundantConditionForSeekClause = value;
}
/**
* The character(s) to be used as a separator in paths encoded in a {@link Name}
* <p>
@ -5854,6 +5883,11 @@ public class Settings
return this;
}
public Settings withRenderRedundantConditionForSeekClause(Boolean value) {
setRenderRedundantConditionForSeekClause(value);
return this;
}
/**
* The character(s) to be used as a separator in paths encoded in a {@link Name}
* <p>
@ -7141,6 +7175,7 @@ public class Settings
builder.append("renderParenthesisAroundSetOperationQueries", renderParenthesisAroundSetOperationQueries);
builder.append("renderVariablesInDerivedTablesForEmulations", renderVariablesInDerivedTablesForEmulations);
builder.append("renderRowConditionForSeekClause", renderRowConditionForSeekClause);
builder.append("renderRedundantConditionForSeekClause", renderRedundantConditionForSeekClause);
builder.append("namePathSeparator", namePathSeparator);
builder.append("bindOffsetDateTimeType", bindOffsetDateTimeType);
builder.append("bindOffsetTimeType", bindOffsetTimeType);
@ -7601,6 +7636,15 @@ public class Settings
return false;
}
}
if (renderRedundantConditionForSeekClause == null) {
if (other.renderRedundantConditionForSeekClause!= null) {
return false;
}
} else {
if (!renderRedundantConditionForSeekClause.equals(other.renderRedundantConditionForSeekClause)) {
return false;
}
}
if (namePathSeparator == null) {
if (other.namePathSeparator!= null) {
return false;
@ -9239,6 +9283,7 @@ public class Settings
result = ((prime*result)+((renderParenthesisAroundSetOperationQueries == null)? 0 :renderParenthesisAroundSetOperationQueries.hashCode()));
result = ((prime*result)+((renderVariablesInDerivedTablesForEmulations == null)? 0 :renderVariablesInDerivedTablesForEmulations.hashCode()));
result = ((prime*result)+((renderRowConditionForSeekClause == null)? 0 :renderRowConditionForSeekClause.hashCode()));
result = ((prime*result)+((renderRedundantConditionForSeekClause == null)? 0 :renderRedundantConditionForSeekClause.hashCode()));
result = ((prime*result)+((namePathSeparator == null)? 0 :namePathSeparator.hashCode()));
result = ((prime*result)+((bindOffsetDateTimeType == null)? 0 :bindOffsetDateTimeType.hashCode()));
result = ((prime*result)+((bindOffsetTimeType == null)? 0 :bindOffsetTimeType.hashCode()));

7
jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
View File

@ -4010,6 +4010,13 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
c = or;
}
if (o.size() > 1 && TRUE.equals(ctx.settings().isRenderRedundantConditionForSeekClause())) {
if (o.get(0).getOrder() != DESC ^ seekBefore)
c = ((Field) o.get(0).$field()).ge(getSeek().get(0)).and(c);
else
c = ((Field) o.get(0).$field()).le(getSeek().get(0)).and(c);
}
return c;
}

7
jOOQ/src/main/resources/org/jooq/xsd/jooq-runtime-3.18.0.xsd
View File

@ -228,6 +228,13 @@ This flag allows for expanding the predicate to the much more verbose, but equiv
by this flag.]]></jxb:javadoc></jxb:property></appinfo></annotation>
</element>
<element name="renderRedundantConditionForSeekClause " type="boolean" minOccurs="0" maxOccurs="1" default="false">
<annotation><appinfo><jxb:property><jxb:javadoc><![CDATA[Whether a redundant <code>(a <= :a)</code> predicate should be rendered for a <code>(a, b) < (:a, :b)</code> predicate for the <code>SEEK</code> clause.
<p>
Some RDBMS may not be able to properly optimise <code>(a, b) < ('a', 'b')</code> or <code>(a < 'a') OR (a = 'a' AND b < 'b')</code>, and choose an appropriate index. By adding an additional redundant predicate,
jOOQ may help the optimiser, e.g. <code>(a <= :a) AND (a, b) < ('a', 'b')</code> or <code>(a <= :a) AND ((a < 'a') OR (a = 'a' AND b < 'b'))</code>]]></jxb:javadoc></jxb:property></appinfo></annotation>
</element>
<element name="namePathSeparator" type="string" minOccurs="0" maxOccurs="1" default=".">
<annotation><appinfo><jxb:property><jxb:javadoc><![CDATA[The character(s) to be used as a separator in paths encoded in a {@link Name}
<p>