github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#2045] Bad hashCode calculation when Records contain arrays or byte[]

Browse Source
This commit is contained in:
Lukas Eder 2012-12-22 20:46:49 +01:00
parent d756297151
commit 5cfde0af20
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
jOOQ/src/main/java/org/jooq/impl/AbstractStore.java
View File

@ -118,7 +118,19 @@ abstract class AbstractStore implements AttachableInternal {
for (int i = 0; i < size(); i++) {
final Object obj = getValue(i);
hashCode = 31 * hashCode + (obj == null ? 0 : obj.hashCode());
if (obj == null) {
hashCode = 31 * hashCode;
}
// [#985] [#2045] Don't use obj.hashCode() on arrays, but avoid
// calculating it as byte[] (BLOBs) can be quite large
else if (obj.getClass().isArray()) {
hashCode = 31 * hashCode;
}
else {
hashCode = 31 * hashCode + obj.hashCode();
}
}
return hashCode;