github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#1535] Oracle ROW_NUMBER() OVER() have mandatory ordering clauses. Push

Browse Source 
down SELECT-level ORDER BY clause to ranking functions if needed -
Prepared integration tests for a future fix
This commit is contained in:
Lukas Eder 2012-07-06 14:01:09 +02:00
parent 1700d832b7
commit 5c921089ed
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
jOOQ-test/src/org/jooq/test/_/testcases/AggregateWindowFunctionTests.java
View File

@ -263,26 +263,31 @@ extends BaseTest<A, AP, B, S, B2S, BS, L, X, DATE, BOOL, D, T, U, I, IPK, T658,
return;
}
// [#1523] Derby, H2 now support the ROW_NUMBER() OVER() window function
// without any window clause, though. HSQLDB can simulate it using ROWNUM()
List<Integer> rows =
create().select(rowNumber().over()).from(TBook()).fetch(0, Integer.class);
assertEquals(asList(1, 2, 3, 4), rows);
switch (getDialect()) {
case DERBY:
case H2:
case HSQLDB:
// [#1535] TODO: Move this out of the switch statement. Oracle
// and other databases should be able to support ORDER-BY-less
// OVER() clauses for ranking functions
// [#1523] Derby, H2 now support the ROW_NUMBER() OVER() window function
// without any window clause, though. HSQLDB can simulate it using ROWNUM()
List<Integer> rows =
create().select(rowNumber().over()).from(TBook()).orderBy(TBook_ID()).fetch(0, Integer.class);
assertEquals(asList(1, 2, 3, 4), rows);
log.info("SKIPPING", "Advanced window function tests");
return;
}
int column = 0;
// ROW_NUMBER()
Result<Record> result =
create().select(TBook_ID(),
// [#1535] TODO: rowNumber().over(),
rowNumber().over()
.partitionByOne()
.orderBy(TBook_ID().desc()),
@ -293,6 +298,10 @@ extends BaseTest<A, AP, B, S, B2S, BS, L, X, DATE, BOOL, D, T, U, I, IPK, T658,
.orderBy(TBook_ID().asc())
.fetch();
// // [#1535] No ORDER BY clause
// column++;
// assertEquals(BOOK_IDS, result.getValues(column));
// Ordered ROW_NUMBER()
column++;
assertEquals(Integer.valueOf(4), result.getValue(0, column));