From 5a63eaaa030d5cf457f3a835dd104372ac7f593b Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Fri, 11 Jan 2013 17:43:53 +0100 Subject: [PATCH] [#2119] Rename Row.getDegree() to Row.size() --- .../_/testcases/ExecuteListenerTests.java | 10 +++--- .../jooq/test/_/testcases/ExoticTests.java | 6 ++-- .../org/jooq/test/_/testcases/FetchTests.java | 6 ++-- .../jooq/test/_/testcases/FormatTests.java | 26 +++++++-------- .../org/jooq/test/_/testcases/JoinTests.java | 4 +-- .../jooq/test/_/testcases/PlainSQLTests.java | 8 ++--- .../test/_/testcases/RoutineAndUDTTests.java | 32 +++++++++---------- .../jooq/test/_/testcases/SelectTests.java | 4 +-- .../src/org/jooq/xtend/BetweenAndSteps.xtend | 2 +- jOOQ-tools/src/org/jooq/xtend/Rows.xtend | 2 +- jOOQ/src/main/java/org/jooq/Row.java | 2 +- .../main/java/org/jooq/impl/MergeImpl.java | 4 +-- .../java/org/jooq/impl/ResultSetImpl.java | 2 +- .../org/jooq/impl/RowBetweenCondition.java | 2 +- jOOQ/src/main/java/org/jooq/impl/RowImpl.java | 2 +- .../java/org/jooq/impl/SelectQueryImpl.java | 2 +- .../main/java/org/jooq/impl/TableAlias.java | 2 +- jOOQ/src/main/java/org/jooq/impl/Utils.java | 2 +- .../test/java/org/jooq/test/BasicTest.java | 18 +++++------ 19 files changed, 68 insertions(+), 68 deletions(-) diff --git a/jOOQ-test/src/org/jooq/test/_/testcases/ExecuteListenerTests.java b/jOOQ-test/src/org/jooq/test/_/testcases/ExecuteListenerTests.java index 720dc0c512..bb365e5321 100644 --- a/jOOQ-test/src/org/jooq/test/_/testcases/ExecuteListenerTests.java +++ b/jOOQ-test/src/org/jooq/test/_/testcases/ExecuteListenerTests.java @@ -374,7 +374,7 @@ extends BaseTest 0) { regex1 += ","; regex2 += ","; @@ -414,10 +414,10 @@ extends BaseTest fetch1 = q.fetch(); assertEquals(1, fetch1.size()); - assertEquals(1, fetch1.fieldsRow().getDegree()); + assertEquals(1, fetch1.fieldsRow().size()); assertEquals("p", fetch1.field(0).getName()); assertEquals("p", fetch1.field("p").getName()); assertEquals("10", fetch1.getValue(0, 0)); @@ -448,7 +448,7 @@ extends BaseTest() { @Override public void next(Record record) { - assertEquals(1, record.fieldsRow().getDegree()); + assertEquals(1, record.fieldsRow().size()); assertEquals("10", record.getValue(0)); count[0] += 1; } @@ -495,7 +495,7 @@ extends BaseTest fetch10 = q.fetchLazy(); assertFalse(fetch10.isClosed()); assertTrue(fetch10.hasNext()); - assertEquals(1, fetch10.fieldsRow().getDegree()); + assertEquals(1, fetch10.fieldsRow().size()); assertEquals("p", fetch10.field(0).getName()); assertEquals("10", fetch10.fetchOne().getValue(0)); assertFalse(fetch10.isClosed()); diff --git a/jOOQ-test/src/org/jooq/test/_/testcases/RoutineAndUDTTests.java b/jOOQ-test/src/org/jooq/test/_/testcases/RoutineAndUDTTests.java index 346cce6ee7..be29f31ccd 100644 --- a/jOOQ-test/src/org/jooq/test/_/testcases/RoutineAndUDTTests.java +++ b/jOOQ-test/src/org/jooq/test/_/testcases/RoutineAndUDTTests.java @@ -950,7 +950,7 @@ extends BaseTest 1 && asList(CUBRID, DERBY, FIREBIRD, MYSQL, ORACLE, SQLITE, SQLSERVER, SYBASE).contains(configuration.getDialect())) { + else if (row.size() > 1 && asList(CUBRID, DERBY, FIREBIRD, MYSQL, ORACLE, SQLITE, SQLSERVER, SYBASE).contains(configuration.getDialect())) { Condition result = r.ge(min).and(r.le(max)); if (not) { diff --git a/jOOQ-tools/src/org/jooq/xtend/Rows.xtend b/jOOQ-tools/src/org/jooq/xtend/Rows.xtend index 0db26bcab5..58c450197a 100644 --- a/jOOQ-tools/src/org/jooq/xtend/Rows.xtend +++ b/jOOQ-tools/src/org/jooq/xtend/Rows.xtend @@ -1206,7 +1206,7 @@ class Rows extends Generators { // ------------------------------------------------------------------------ @Override - public final int getDegree() { + public final int size() { return fields.length; } diff --git a/jOOQ/src/main/java/org/jooq/Row.java b/jOOQ/src/main/java/org/jooq/Row.java index 1fba093a92..574aa30856 100644 --- a/jOOQ/src/main/java/org/jooq/Row.java +++ b/jOOQ/src/main/java/org/jooq/Row.java @@ -49,7 +49,7 @@ public interface Row extends QueryPart { /** * Get the degree of this row value expression */ - int getDegree(); + int size(); /** * Get a specific field from this row. diff --git a/jOOQ/src/main/java/org/jooq/impl/MergeImpl.java b/jOOQ/src/main/java/org/jooq/impl/MergeImpl.java index 1b53b64f31..69dd2cf786 100644 --- a/jOOQ/src/main/java/org/jooq/impl/MergeImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/MergeImpl.java @@ -431,7 +431,7 @@ implements FieldList v = new FieldList(); Row row = h2Select.fieldsRow(); - for (int i = 0; i < row.getDegree(); i++) { + for (int i = 0; i < row.size(); i++) { v.add(row.field(i).as("s" + (i + 1))); } @@ -503,7 +503,7 @@ implements Map, Field> update = new LinkedHashMap, Field>(); Map, Field> insert = new LinkedHashMap, Field>(); - for (int i = 0; i < src.fieldsRow().getDegree(); i++) { + for (int i = 0; i < src.fieldsRow().size(); i++) { // Oracle does not allow to update fields from the ON clause if (!onFields.contains(getH2Fields().get(i))) { diff --git a/jOOQ/src/main/java/org/jooq/impl/ResultSetImpl.java b/jOOQ/src/main/java/org/jooq/impl/ResultSetImpl.java index fbe812f425..6b23244c83 100644 --- a/jOOQ/src/main/java/org/jooq/impl/ResultSetImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/ResultSetImpl.java @@ -1157,7 +1157,7 @@ class ResultSetImpl extends JDBC41ResultSet implements ResultSet, Serializable { public final int getColumnCount() throws SQLException { checkNotClosed(); - return result.fieldsRow().getDegree(); + return result.fieldsRow().size(); } @Override diff --git a/jOOQ/src/main/java/org/jooq/impl/RowBetweenCondition.java b/jOOQ/src/main/java/org/jooq/impl/RowBetweenCondition.java index 159d10eda9..47045d193d 100644 --- a/jOOQ/src/main/java/org/jooq/impl/RowBetweenCondition.java +++ b/jOOQ/src/main/java/org/jooq/impl/RowBetweenCondition.java @@ -698,7 +698,7 @@ implements // These dialects either don't support row value expressions, or they // Can't handle row value expressions with the BETWEEN predicate - else if (row.getDegree() > 1 && asList(CUBRID, DERBY, FIREBIRD, MYSQL, ORACLE, SQLITE, SQLSERVER, SYBASE).contains(configuration.getDialect())) { + else if (row.size() > 1 && asList(CUBRID, DERBY, FIREBIRD, MYSQL, ORACLE, SQLITE, SQLSERVER, SYBASE).contains(configuration.getDialect())) { Condition result = r.ge(min).and(r.le(max)); if (not) { diff --git a/jOOQ/src/main/java/org/jooq/impl/RowImpl.java b/jOOQ/src/main/java/org/jooq/impl/RowImpl.java index 692c7e05cc..351acc7e84 100644 --- a/jOOQ/src/main/java/org/jooq/impl/RowImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/RowImpl.java @@ -200,7 +200,7 @@ implements // ------------------------------------------------------------------------ @Override - public final int getDegree() { + public final int size() { return fields.length; } diff --git a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java index 5e5a3a1471..c41d1fbf7c 100644 --- a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java @@ -758,7 +758,7 @@ class SelectQueryImpl extends AbstractSelect implements Sel } private final boolean knownTable(Table table) { - return table.fieldsRow().getDegree() > 0; + return table.fieldsRow().size() > 0; } @SuppressWarnings("unchecked") diff --git a/jOOQ/src/main/java/org/jooq/impl/TableAlias.java b/jOOQ/src/main/java/org/jooq/impl/TableAlias.java index 1b8e9095cc..5ecb39d5a6 100644 --- a/jOOQ/src/main/java/org/jooq/impl/TableAlias.java +++ b/jOOQ/src/main/java/org/jooq/impl/TableAlias.java @@ -82,7 +82,7 @@ class TableAlias extends AbstractTable { */ private final void registerFields(String[] fieldAliases) { Row row = this.alias.wrapped().fieldsRow(); - int size = row.getDegree(); + int size = row.size(); for (int i = 0; i < size; i++) { Field field = row.field(i); diff --git a/jOOQ/src/main/java/org/jooq/impl/Utils.java b/jOOQ/src/main/java/org/jooq/impl/Utils.java index efb25718b6..cd6b1a2c43 100644 --- a/jOOQ/src/main/java/org/jooq/impl/Utils.java +++ b/jOOQ/src/main/java/org/jooq/impl/Utils.java @@ -2057,7 +2057,7 @@ final class Utils { List values = PostgresUtils.toPGObject(object.toString()); Row row = record.fieldsRow(); - for (int i = 0; i < row.getDegree(); i++) { + for (int i = 0; i < row.size(); i++) { pgSetValue(record, row.field(i), values.get(i)); } diff --git a/jOOQ/src/test/java/org/jooq/test/BasicTest.java b/jOOQ/src/test/java/org/jooq/test/BasicTest.java index a36b4bc402..3e0be99564 100644 --- a/jOOQ/src/test/java/org/jooq/test/BasicTest.java +++ b/jOOQ/src/test/java/org/jooq/test/BasicTest.java @@ -535,15 +535,15 @@ public class BasicTest extends AbstractTest { RowN t23 = row(1, "2", 3, "4", 5, "6", 7, "8", 9, "10", 11, "12", 13, "14", 15, "16", 17, "18", 19, "20", 21, "22", 23); // General info - assertEquals(1, t1.getDegree()); - assertEquals(2, t2.getDegree()); - assertEquals(3, t3.getDegree()); - assertEquals(4, t4.getDegree()); - assertEquals(5, t5.getDegree()); - assertEquals(6, t6.getDegree()); - assertEquals(7, t7.getDegree()); - assertEquals(8, t8.getDegree()); - assertEquals(23, t23.getDegree()); + assertEquals(1, t1.size()); + assertEquals(2, t2.size()); + assertEquals(3, t3.size()); + assertEquals(4, t4.size()); + assertEquals(5, t5.size()); + assertEquals(6, t6.size()); + assertEquals(7, t7.size()); + assertEquals(8, t8.size()); + assertEquals(23, t23.size()); // Accessors assertEquals(val(1), t1.field1());