From 5830b1b0d56797fb3d8120cf714a04424c53b26b Mon Sep 17 00:00:00 2001 From: Knut Wannheden Date: Thu, 22 Aug 2019 14:24:10 +0200 Subject: [PATCH] [jOOQ/jOOQ#9071] Fix for DefaultConfiguration#derive() `DefaultConfiguration#derive()` could lead to surprising effects because the derived `Configuration` would be linked to a `MetaProvider` which still referenced the original `Configuration`. --- .../org/jooq/impl/DefaultConfiguration.java | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/DefaultConfiguration.java b/jOOQ/src/main/java/org/jooq/impl/DefaultConfiguration.java index 7da97b6708..b47b02a21d 100644 --- a/jOOQ/src/main/java/org/jooq/impl/DefaultConfiguration.java +++ b/jOOQ/src/main/java/org/jooq/impl/DefaultConfiguration.java @@ -186,27 +186,27 @@ public class DefaultConfiguration implements Configuration { * * @param configuration The pre-existing configuration. */ - DefaultConfiguration(Configuration configuration) { + DefaultConfiguration(DefaultConfiguration configuration) { this( - configuration.connectionProvider(), - configuration.metaProvider(), - configuration.executorProvider(), - configuration.transactionProvider(), - configuration.recordMapperProvider(), - configuration.recordUnmapperProvider(), - configuration.recordListenerProviders(), - configuration.executeListenerProviders(), - configuration.visitListenerProviders(), - configuration.transactionListenerProviders(), - configuration.diagnosticsListenerProviders(), - configuration.unwrapperProvider(), - configuration.converterProvider(), + configuration.connectionProvider, + configuration.metaProvider, + configuration.executorProvider, + configuration.transactionProvider, + configuration.recordMapperProvider, + configuration.recordUnmapperProvider, + configuration.recordListenerProviders, + configuration.executeListenerProviders, + configuration.visitListenerProviders, + configuration.transactionListenerProviders, + configuration.diagnosticsListenerProviders, + configuration.unwrapperProvider, + configuration.converterProvider, - configuration.clock(), + configuration.clock, - configuration.dialect(), - configuration.settings(), - configuration.data() + configuration.dialect, + configuration.settings, + configuration.data ); }