github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#15967] Implicit path correlation shouldn't generate

Browse Source 
correlation predicate if correlation isn't in scope
This commit is contained in:
Lukas Eder 2023-12-20 13:35:46 +01:00
parent 480329ab26
commit 514b39d359
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
View File

@ -2926,10 +2926,14 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
while ((next = TableImpl.path(curr)) != null) {
tables.add(curr);
// [#14985] [#15967] In some edge cases, users may have chosen to use a path in the FROM
// clause, whose path root isn't in scope. We mustn't put it in scope here!
if (!ctx.inScope(curr))
ctx.scopeRegister(curr, true);
if (ctx.inScope(next))
break;
ctx.scopeRegister(next, true);
curr = next;
}
@ -4355,8 +4359,10 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
private static final void addPathConditions(Context<?> ctx, ConditionProviderImpl result, Table<?> t) {
if (t instanceof TableImpl<?> ti) {
// [#14985] TODO: Should we check whether ti.child is in scope, or leave that to the user?
if (ti.path != null)
// [#14985] [#15967] In some edge cases, users may have chosen to use a path in the FROM
// clause, whose path root isn't in scope. In that case, we must ignore
// the path.
if (ti.path != null && ctx.inScope(ti.path))
result.addConditions(ti.pathCondition());
}
}