github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#3947] Avoid creating unnecessary Iterators and ArrayLists in AbstractStore.getAttachables()

Browse Source
This commit is contained in:
lukaseder 2015-01-14 16:23:09 +01:00
parent e248376121
commit 5031910d2a
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jOOQ/src/main/java/org/jooq/impl/AbstractRecord.java
View File

@ -59,6 +59,7 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.BitSet;
import java.util.Collection;
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
@ -143,16 +144,19 @@ abstract class AbstractRecord extends AbstractStore implements Record {
@Override
final List<Attachable> getAttachables() {
List<Attachable> result = new ArrayList<Attachable>();
List<Attachable> result = null;
int size = size();
for (int i = 0; i < size; i++) {
if (values[i] instanceof Attachable) {
if (result == null)
result = new ArrayList<Attachable>();
result.add((Attachable) values[i]);
}
}
return result;
return result == null ? Collections.<Attachable>emptyList() : result;
}
// ------------------------------------------------------------------------

7
jOOQ/src/main/java/org/jooq/impl/AbstractStore.java
View File

@ -85,9 +85,10 @@ abstract class AbstractStore implements AttachableInternal {
public final void attach(Configuration c) {
configuration = c;
for (Attachable attachable : getAttachables()) {
attachable.attach(c);
}
final List<Attachable> attachables = getAttachables();
final int size = attachables.size();
for (int i = 0; i < size; i++)
attachables.get(i).attach(c);
}
@Override