From 4f51cb60714cdd9de5c7abc4ffe124d7841e4c48 Mon Sep 17 00:00:00 2001
From: lukaseder <lukas.eder@gmail.com>
Date: Sun, 20 Sep 2015 15:15:02 +0200
Subject: [PATCH] [#4476] Issue a warning when Record.field(Field) runs into
 ambiguous columns

---
 jOOQ/src/main/java/org/jooq/impl/Fields.java | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/jOOQ/src/main/java/org/jooq/impl/Fields.java b/jOOQ/src/main/java/org/jooq/impl/Fields.java
index e7e90c70e3..88580fdbf9 100644
--- a/jOOQ/src/main/java/org/jooq/impl/Fields.java
+++ b/jOOQ/src/main/java/org/jooq/impl/Fields.java
@@ -54,6 +54,7 @@ import org.jooq.Record;
 import org.jooq.RecordType;
 import org.jooq.Table;
 import org.jooq.TableField;
+import org.jooq.tools.JooqLogger;
 
 /**
  * A simple wrapper for <code>Field[]</code>, providing some useful lookup
@@ -63,8 +64,9 @@ import org.jooq.TableField;
  */
 class Fields<R extends Record> extends AbstractQueryPart implements RecordType<R> {
 
-    private static final long serialVersionUID = -6911012275707591576L;
-    Field<?>[]                fields;
+    private static final long       serialVersionUID = -6911012275707591576L;
+    private static final JooqLogger log              = JooqLogger.getLogger(Fields.class);
+    Field<?>[]                      fields;
 
     Fields(Field<?>... fields) {
         this.fields = fields;
@@ -110,8 +112,14 @@ class Fields<R extends Record> extends AbstractQueryPart implements RecordType<R
             }
 
             // In case no exact match was found, return the first field with matching name
-            if (columnMatch == null && f.getName().equals(fieldName))
-                columnMatch = f;
+            if (f.getName().equals(fieldName)) {
+                if (columnMatch == null)
+                    columnMatch = f;
+                else
+                    // [#4476] [#4477] This might be unintentional from a user
+                    // perspective, e.g. when ambiguous ID columns are present.
+                    log.info("Ambiguous match found for " + fieldName + ". Both " + columnMatch + " and " + f + " match.");
+            }
         }
 
         return (Field<T>) columnMatch;