[#837] Avoid final keyword on Object methods, such as .equals(), .hashCode(), .toString()
This commit is contained in:
parent
0548a78583
commit
4abcf0059e
@ -451,7 +451,7 @@ public abstract class AbstractDataType<T> implements DataType<T> {
|
||||
}
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
return getClass().getSimpleName() + " [" + type + ", " + typeName + "]";
|
||||
}
|
||||
}
|
||||
|
||||
@ -215,7 +215,7 @@ abstract class AbstractQueryPart implements QueryPartInternal, AttachableInterna
|
||||
// -------------------------------------------------------------------------
|
||||
|
||||
@Override
|
||||
public final boolean equals(Object that) {
|
||||
public boolean equals(Object that) {
|
||||
if (that instanceof QueryPart) {
|
||||
String sql1 = create().renderInlined(this);
|
||||
String sql2 = create().renderInlined((QueryPart) that);
|
||||
@ -227,12 +227,12 @@ abstract class AbstractQueryPart implements QueryPartInternal, AttachableInterna
|
||||
}
|
||||
|
||||
@Override
|
||||
public final int hashCode() {
|
||||
public int hashCode() {
|
||||
return create().renderInlined(this).hashCode();
|
||||
}
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
try {
|
||||
return create().renderInlined(this);
|
||||
}
|
||||
|
||||
@ -174,7 +174,7 @@ abstract class AbstractRecord extends AbstractStore<Object> implements Record {
|
||||
}
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
return getClass().getSimpleName() + " [values=" + Arrays.asList(getValues()) + "]";
|
||||
}
|
||||
|
||||
|
||||
@ -272,7 +272,7 @@ abstract class AbstractStore<T> implements Store<T>, AttachableInternal {
|
||||
}
|
||||
|
||||
@Override
|
||||
public final boolean equals(Object obj) {
|
||||
public boolean equals(Object obj) {
|
||||
if (obj instanceof Store) {
|
||||
final Store<?> that = (Store<?>) obj;
|
||||
|
||||
|
||||
@ -189,7 +189,7 @@ public class ArrayRecordImpl<T> extends AbstractStore<T> implements ArrayRecord<
|
||||
}
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
return getClass().getSimpleName() + " [values=" + getList() + "]";
|
||||
}
|
||||
|
||||
|
||||
@ -118,7 +118,7 @@ class AttachableImpl implements AttachableInternal {
|
||||
}
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
if (configuration == null) {
|
||||
return "[ detached ]";
|
||||
}
|
||||
|
||||
@ -327,7 +327,7 @@ class DefaultBindContext extends AbstractContext<BindContext> implements BindCon
|
||||
// ------------------------------------------------------------------------
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
StringBuilder sb = new StringBuilder();
|
||||
|
||||
sb.append("binding [index ");
|
||||
|
||||
@ -192,7 +192,7 @@ class DefaultRenderContext extends AbstractContext<RenderContext> implements Ren
|
||||
// ------------------------------------------------------------------------
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
StringBuilder sb = new StringBuilder();
|
||||
|
||||
sb.append("rendering [");
|
||||
|
||||
@ -2759,7 +2759,7 @@ public class Factory implements Configuration {
|
||||
}
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
return "Factory [connected=" + (connection != null) + ", dialect=" + dialect + ", mapping=" + mapping + "]";
|
||||
}
|
||||
|
||||
|
||||
@ -70,12 +70,12 @@ class IdentityImpl<R extends Record, T> implements Identity<R, T> {
|
||||
}
|
||||
|
||||
@Override
|
||||
public final int hashCode() {
|
||||
public int hashCode() {
|
||||
return toString().hashCode();
|
||||
}
|
||||
|
||||
@Override
|
||||
public final boolean equals(Object obj) {
|
||||
public boolean equals(Object obj) {
|
||||
if (obj instanceof Identity) {
|
||||
return toString().equals(obj.toString());
|
||||
}
|
||||
@ -84,7 +84,7 @@ class IdentityImpl<R extends Record, T> implements Identity<R, T> {
|
||||
}
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
return field.toString();
|
||||
}
|
||||
}
|
||||
|
||||
@ -1261,18 +1261,18 @@ class ResultImpl<R extends Record> implements Result<R>, AttachableInternal {
|
||||
// -------------------------------------------------------------------------
|
||||
|
||||
@Override
|
||||
public final String toString() {
|
||||
public String toString() {
|
||||
return format();
|
||||
}
|
||||
|
||||
@Override
|
||||
public final int hashCode() {
|
||||
public int hashCode() {
|
||||
return records.hashCode();
|
||||
}
|
||||
|
||||
@SuppressWarnings("unchecked")
|
||||
@Override
|
||||
public final boolean equals(Object obj) {
|
||||
public boolean equals(Object obj) {
|
||||
if (obj instanceof ResultImpl) {
|
||||
ResultImpl<R> other = (ResultImpl<R>) obj;
|
||||
return records.equals(other.records);
|
||||
|
||||
Loading…
Reference in New Issue
Block a user