From 342c7693099e49f043c520cfc9d15f0293e98eda Mon Sep 17 00:00:00 2001 From: Lukas Eder Date: Sat, 11 May 2013 09:46:46 +0200 Subject: [PATCH] Minor optimisation: Avoid &= and |= where possible --- jOOQ/src/main/java/org/jooq/impl/AbstractRecord.java | 2 +- jOOQ/src/main/java/org/jooq/impl/Value.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/AbstractRecord.java b/jOOQ/src/main/java/org/jooq/impl/AbstractRecord.java index d5113102b8..f1a6951cd6 100644 --- a/jOOQ/src/main/java/org/jooq/impl/AbstractRecord.java +++ b/jOOQ/src/main/java/org/jooq/impl/AbstractRecord.java @@ -531,7 +531,7 @@ abstract class AbstractRecord extends AbstractStore implements Record { boolean isKeySet = true; for (Field field : key.getFields()) { - isKeySet &= (field(field) != null); + isKeySet = isKeySet && (field(field) != null); } if (isKeySet) { diff --git a/jOOQ/src/main/java/org/jooq/impl/Value.java b/jOOQ/src/main/java/org/jooq/impl/Value.java index 1f20b45f5a..0886a5382e 100644 --- a/jOOQ/src/main/java/org/jooq/impl/Value.java +++ b/jOOQ/src/main/java/org/jooq/impl/Value.java @@ -100,10 +100,10 @@ class Value implements Serializable { // [#945] Be sure that isChanged is never reset to false if (value == null) { - isChanged |= val != null; + isChanged = isChanged || (val != null); } else { - isChanged |= !value.equals(val); + isChanged = isChanged || (!value.equals(val)); } }