github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#9104] Fix missing parenthesis regression in OSS edition

Browse Source 
In commit jOOQ/jOOQ@a55a362fd8 the SQL
rendering logic for parenthesis pairs in `QuantifiedSelectImpl` and
`RowSubqueryCondition` was inadvertently broken.
This commit is contained in:
Knut Wannheden 2019-08-30 08:26:44 +02:00
parent 4c54d82a7e
commit 2fb28a8956
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jOOQ/src/main/java/org/jooq/impl/QuantifiedSelectImpl.java
View File

@ -95,13 +95,9 @@ final class QuantifiedSelectImpl<R extends Record> extends AbstractQueryPart imp
ctx.visit(quantifier.toKeyword());
boolean extraParentheses = false;
ctx.sql(extraParentheses ? " ((" : " (");
ctx.subquery(true)
.formatIndentStart()
@ -111,9 +107,7 @@ final class QuantifiedSelectImpl<R extends Record> extends AbstractQueryPart imp
.formatNewLine()
.subquery(false);
ctx.sql(extraParentheses ? "))" : ")");
}
@SuppressWarnings({ "rawtypes", "unchecked" })

8
jOOQ/src/main/java/org/jooq/impl/RowSubqueryCondition.java
View File

@ -220,10 +220,10 @@ final class RowSubqueryCondition extends AbstractCondition {
if (rightQuantified == null) {
// Some databases need extra parentheses around the RHS
boolean extraParentheses = false;
ctx.sql(extraParentheses ? "((" : "(");
@ -239,7 +239,7 @@ final class RowSubqueryCondition extends AbstractCondition {
ctx.sql(extraParentheses ? "))" : ")");
}
// [#2054] Quantified row value expression comparison predicates shouldn't have parentheses before ANY or ALL