github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#9975] Use a more generics friendly super type for casts

Browse Source 
SelectImpl has 23 type variables, so a rawtype reference seems unavoidable. But we don't need to use SelectImpl here. The super type AbstractDelegatingQuery<?> with a single type variable can be used just the same.
This commit is contained in:
Lukas Eder 2020-03-19 20:31:18 +01:00
parent 3aa69e298b
commit 1d329bf6aa
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
View File

@ -1918,9 +1918,9 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
if (s2 instanceof SelectQueryImpl
&& ((SelectQueryImpl<?>) s2).unionOp.size() > 0)
return true;
else if (s2 instanceof SelectImpl
&& ((SelectImpl) s2).getDelegate() instanceof SelectQueryImpl
&& ((SelectQueryImpl<?>) ((SelectImpl) s2).getDelegate()).unionOp.size() > 0)
else if (s2 instanceof AbstractDelegatingQuery
&& ((AbstractDelegatingQuery<?>) s2).getDelegate() instanceof SelectQueryImpl
&& ((SelectQueryImpl<?>) ((AbstractDelegatingQuery<?>) s2).getDelegate()).unionOp.size() > 0)
return true;
return false;
@ -1942,9 +1942,9 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
if (s2 instanceof SelectQueryImpl
&& unionParensRequired((SelectQueryImpl<?>) s2))
return true;
else if (s2 instanceof SelectImpl
&& ((SelectImpl) s2).getDelegate() instanceof SelectQueryImpl
&& unionParensRequired((SelectQueryImpl<?>) ((SelectImpl) s2).getDelegate()))
else if (s2 instanceof AbstractDelegatingQuery
&& ((AbstractDelegatingQuery<?>) s2).getDelegate() instanceof SelectQueryImpl
&& unionParensRequired((SelectQueryImpl<?>) ((AbstractDelegatingQuery<?>) s2).getDelegate()))
return true;
return false;