github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#12078] SQL Server UpdatableRecord.refresh() is unnecessary

Browse Source 
when calling UpdatableRecord.store()
This commit is contained in:
Lukas Eder 2021-06-30 15:44:04 +02:00
parent 7318d893d0
commit 1aa725bbf3
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
jOOQ/src/main/java/org/jooq/impl/TableRecordImpl.java
View File

@ -48,6 +48,7 @@ import static org.jooq.SQLDialect.MYSQL;
// ...
// ...
import static org.jooq.conf.SettingsTools.updatablePrimaryKeys;
import static org.jooq.impl.AbstractDMLQuery.EMULATE_RETURNING_WITH_OUTPUT;
import static org.jooq.impl.RecordDelegate.delegate;
import static org.jooq.impl.RecordDelegate.RecordLifecycleType.INSERT;
import static org.jooq.impl.Tools.EMPTY_FIELD;
@ -206,7 +207,13 @@ public class TableRecordImpl<R extends TableRecord<R>> extends AbstractQualified
// [#1859] In some databases, not all fields can be fetched via getGeneratedKeys()
if (TRUE.equals(configuration().settings().isReturnAllOnUpdatableRecord())
&& REFRESH_GENERATED_KEYS.contains(configuration().dialect())
&& (REFRESH_GENERATED_KEYS.contains(configuration().dialect())
)
&& this instanceof UpdatableRecord)
((UpdatableRecord<?>) this).refresh(key.toArray(EMPTY_FIELD));
}