github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#1667] Bad variable binding when NULLS FIRST, NULLS LAST is simulated

Browse Source 
in SQL Server and other databases
This commit is contained in:
Lukas Eder 2012-08-04 12:01:10 +02:00
parent e0bc94b312
commit 18deada0b9
2 changed files with 37 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
jOOQ-test/src/org/jooq/test/_/testcases/OrderByTests.java
View File

@ -129,25 +129,36 @@ extends BaseTest<A, AP, B, S, B2S, BS, L, X, DATE, BOOL, D, T, U, I, IPK, T658,
.values(3, "Döblin")
.execute();
Result<A> authors =
Result<A> authors1 =
create().selectFrom(TAuthor())
.orderBy(
TAuthor_FIRST_NAME().asc().nullsFirst())
.fetch();
assertNull(authors.getValue(0, TAuthor_FIRST_NAME()));
assertEquals("George", authors.getValue(1, TAuthor_FIRST_NAME()));
assertEquals("Paulo", authors.getValue(2, TAuthor_FIRST_NAME()));
assertNull(authors1.getValue(0, TAuthor_FIRST_NAME()));
assertEquals("George", authors1.getValue(1, TAuthor_FIRST_NAME()));
assertEquals("Paulo", authors1.getValue(2, TAuthor_FIRST_NAME()));
authors =
Result<A> authors2 =
create().selectFrom(TAuthor())
.orderBy(
TAuthor_FIRST_NAME().asc().nullsLast())
.fetch();
assertEquals("George", authors.getValue(0, TAuthor_FIRST_NAME()));
assertEquals("Paulo", authors.getValue(1, TAuthor_FIRST_NAME()));
assertNull(authors.getValue(2, TAuthor_FIRST_NAME()));
assertEquals("George", authors2.getValue(0, TAuthor_FIRST_NAME()));
assertEquals("Paulo", authors2.getValue(1, TAuthor_FIRST_NAME()));
assertNull(authors2.getValue(2, TAuthor_FIRST_NAME()));
// [#1667] Check correct behaviour when bind values are involved
Result<A> authors3 =
create().selectFrom(TAuthor())
.orderBy(
TAuthor_FIRST_NAME().substring(3).asc().nullsLast())
.fetch();
assertEquals("George", authors3.getValue(0, TAuthor_FIRST_NAME()));
assertEquals("Paulo", authors3.getValue(1, TAuthor_FIRST_NAME()));
assertNull(authors3.getValue(2, TAuthor_FIRST_NAME()));
}
@Test

18
jOOQ/src/main/java/org/jooq/impl/SortFieldImpl.java
View File

@ -166,6 +166,24 @@ class SortFieldImpl<T> extends AbstractNamedTypeProviderQueryPart<T> implements
@Override
public final void bind(BindContext context) {
// [#1667] Some dialects simulate NULLS { FIRST | LAST } clauses. They
// will need to bind the sort field twice
if (nullsFirst || nullsLast) {
switch (context.getDialect()) {
case DB2:
case ASE:
case CUBRID:
case INGRES:
case MYSQL:
case SQLITE:
case SQLSERVER:
case SYBASE: {
context.bind(field);
}
}
}
context.bind(field);
}
}