github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#4922] A negligible amount of CPU is spent in String.indexOf() because of identifier escaping

Browse Source
This commit is contained in:
lukaseder 2016-01-10 19:14:51 +01:00
parent c2a75da763
commit 145f2dcd47
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
jOOQ/src/main/java/org/jooq/impl/DefaultRenderContext.java
View File

@ -349,9 +349,20 @@ class DefaultRenderContext extends AbstractContext<RenderContext> implements Ren
else {
String[][] quotes = QUOTES.get(family);
sql(quotes[QUOTE_START_DELIMITER][0]);
sql(StringUtils.replace(literal, quotes[QUOTE_END_DELIMITER][0], quotes[QUOTE_END_DELIMITER_ESCAPED][0]));
sql(quotes[QUOTE_END_DELIMITER][0]);
char start = quotes[QUOTE_START_DELIMITER][0].charAt(0);
char end = quotes[QUOTE_END_DELIMITER][0].charAt(0);
sql(start);
// [#4922] This micro optimisation does seem to have a significant
// effect as the replace call can be avoided in almost all
// situations
if (literal.indexOf(end) > -1)
sql(StringUtils.replace(literal, quotes[QUOTE_END_DELIMITER][0], quotes[QUOTE_END_DELIMITER_ESCAPED][0]));
else
sql(literal);
sql(end);
}
return this;