github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#16796] Incorrect emulation of inverse distribution functions

Browse Source 
with FILTER clause
This commit is contained in:
Lukas Eder 2024-06-07 14:10:57 +02:00
parent 343deb13c8
commit 0d408bdeba
4 changed files with 31 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
jOOQ/src/main/java/org/jooq/impl/AbstractAggregateFunction.java
View File

@ -165,7 +165,7 @@ implements
/**
* Render <code>KEEP (DENSE_RANK [FIRST | LAST] ORDER BY {…})</code> clause
*/
private final void acceptKeepDenseRankOrderByClause(Context<?> ctx) {
final void acceptKeepDenseRankOrderByClause(Context<?> ctx) {
if (!Tools.isEmpty(keepDenseRankOrderBy)) {
switch (ctx.family()) {
@ -210,6 +210,8 @@ implements
if (withinGroupOrderBy.isEmpty())
ctx.visit(K_NULL);
else if (filter.hasWhere() && !supportsFilter(ctx) && applyFilterToWithinGroup(ctx))
ctx.visit(wrap(withinGroupOrderBy).map((arg, i) -> DSL.when(filter, arg.$field()).sort(arg.$sortOrder())));
else
ctx.visit(withinGroupOrderBy);
@ -298,17 +300,21 @@ implements
else
ctx.visit(wrap(args).map((arg, i) -> applyFilter(ctx, arg, i) ? DSL.when(filter, arg == ASTERISK.get() ? one() : arg) : arg).map(fun));
ctx.visit(wrap(args).map((arg, i) -> applyFilterToArgument(ctx, arg, i) ? DSL.when(filter, arg == ASTERISK.get() ? one() : arg) : arg).map(fun));
}
Field<?> applyMap(Context<?> ctx, Field<?> arg) {
/* non-final */ Field<?> applyMap(Context<?> ctx, Field<?> arg) {
return arg;
}
boolean applyFilter(Context<?> ctx, Field<?> arg, int i) {
/* non-final */ boolean applyFilterToArgument(Context<?> ctx, Field<?> arg, int i) {
return true;
}
/* non-final */ boolean applyFilterToWithinGroup(Context<?> ctx) {
return false;
}

2
jOOQ/src/main/java/org/jooq/impl/ListAgg.java
View File

@ -185,7 +185,7 @@ implements
}
@Override
final boolean applyFilter(Context<?> ctx, Field<?> arg, int i) {
final boolean applyFilterToArgument(Context<?> ctx, Field<?> arg, int i) {
return i == 0;
}

10
jOOQ/src/main/java/org/jooq/impl/PercentileCont.java
View File

@ -119,6 +119,16 @@ implements
}
}
@Override
final boolean applyFilterToArgument(Context<?> ctx, Field<?> arg, int i) {
return false;
}
@Override
final boolean applyFilterToWithinGroup(Context<?> ctx) {
return true;
}
// -------------------------------------------------------------------------

10
jOOQ/src/main/java/org/jooq/impl/PercentileDisc.java
View File

@ -119,6 +119,16 @@ implements
}
}
@Override
final boolean applyFilterToArgument(Context<?> ctx, Field<?> arg, int i) {
return false;
}
@Override
final boolean applyFilterToWithinGroup(Context<?> ctx) {
return true;
}
// -------------------------------------------------------------------------