From 0339de9bacb2de7c9e5ffdc0ddba644a804787b5 Mon Sep 17 00:00:00 2001 From: lukaseder Date: Tue, 19 Jun 2018 12:58:52 +0200 Subject: [PATCH] [#7584] Regression in DSL.or(Collection) when passing empty collection --- jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java b/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java index 55c59bc966..23f5d6d789 100644 --- a/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java +++ b/jOOQ/src/main/java/org/jooq/impl/CombinedCondition.java @@ -43,7 +43,6 @@ import static org.jooq.Clause.CONDITION_AND; import static org.jooq.Clause.CONDITION_OR; import static org.jooq.Operator.AND; import static org.jooq.impl.DSL.falseCondition; -import static org.jooq.impl.DSL.noCondition; import static org.jooq.impl.DSL.trueCondition; import static org.jooq.impl.Keywords.K_AND; import static org.jooq.impl.Keywords.K_OR; @@ -80,9 +79,6 @@ final class CombinedCondition extends AbstractCondition { } static Condition of(Operator operator, Collection conditions) { - if (conditions.isEmpty()) - return noCondition(); - CombinedCondition result = null; Condition first = null; @@ -101,8 +97,10 @@ final class CombinedCondition extends AbstractCondition { return result; else if (first != null) return first; + else if (operator == AND) + return trueCondition(); else - return noCondition(); + return falseCondition(); } private CombinedCondition(Operator operator, int size) {