github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#2863] Remove unnecessarily cached Connection in DataSourceConnectionProvider

Browse Source
This commit is contained in:
Lukas Eder 2013-11-27 11:23:53 +01:00
parent da06c1a3bd
commit 01d95eab79
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
jOOQ/src/main/java/org/jooq/impl/DataSourceConnectionProvider.java
View File

@ -71,7 +71,6 @@ import org.jooq.exception.DataAccessException;
public class DataSourceConnectionProvider implements ConnectionProvider {
private final DataSource dataSource;
private Connection connection;
public DataSourceConnectionProvider(DataSource dataSource) {
this.dataSource = dataSource;
@ -83,27 +82,18 @@ public class DataSourceConnectionProvider implements ConnectionProvider {
@Override
public Connection acquire() {
if (null == connection) {
try {
connection = dataSource.getConnection();
}
catch (SQLException e) {
throw new DataAccessException("Error getting connection from data source " + dataSource, e);
}
try {
return dataSource.getConnection();
}
catch (SQLException e) {
throw new DataAccessException("Error getting connection from data source " + dataSource, e);
}
return connection;
}
@Override
public void release(Connection released) {
if (this.connection != released) {
throw new IllegalArgumentException("Expected " + this.connection + " but got " + released);
}
public void release(Connection connection) {
try {
connection.close();
this.connection = null;
}
catch (SQLException e) {
throw new DataAccessException("Error closing connection " + connection, e);