From 016928311dca9fd15a438aa466748cd92018f217 Mon Sep 17 00:00:00 2001 From: lukaseder Date: Wed, 8 Apr 2015 15:46:18 +0200 Subject: [PATCH] [#4151] FOR UPDATE .. OF doesn't allow qualified column names --- jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java | 8 +++++--- jOOQ/src/main/java/org/jooq/impl/TableList.java | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java index 1854d4be9e..3d8ee61c8e 100644 --- a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java +++ b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java @@ -469,8 +469,10 @@ class SelectQueryImpl extends AbstractResultQuery implement .keyword("for update"); if (!forUpdateOf.isEmpty()) { - context.sql(' ').keyword("of").sql(' '); - Utils.fieldNames(context, forUpdateOf); + context.sql(' ').keyword("of") + .sql(' ').visit(forUpdateOf); + + // Utils.fieldNames(context, forUpdateOf); } else if (!forUpdateOfTables.isEmpty()) { context.sql(' ').keyword("of").sql(' '); @@ -486,7 +488,7 @@ class SelectQueryImpl extends AbstractResultQuery implement xxxx xxxxxxx xx [/pro] */ case DERBY: { - forUpdateOfTables.toSQLFieldNames(context); + forUpdateOfTables.toSQLFields(context); break; } diff --git a/jOOQ/src/main/java/org/jooq/impl/TableList.java b/jOOQ/src/main/java/org/jooq/impl/TableList.java index cae49d15f3..9da837a907 100644 --- a/jOOQ/src/main/java/org/jooq/impl/TableList.java +++ b/jOOQ/src/main/java/org/jooq/impl/TableList.java @@ -76,13 +76,13 @@ class TableList extends QueryPartList> { * Get a list of names of the NamedQueryParts contained in this * list. */ - final void toSQLFieldNames(Context ctx) { + final void toSQLFields(Context ctx) { String separator = ""; for (Table table : this) { for (Field field : table.fieldsRow().fields()) { ctx.sql(separator); - ctx.literal(field.getName()); + ctx.visit(field); separator = ", "; }