* Start of tracing prototype
* Created initial implementation of azure-core-opentelemetry package
* New version of enabling MSVCRT Lib for static configs
* Attempt to add OpenTelemetry tests to build
* Take a dependency on OpenTelemetry version 1.3
* Added service API level tracing support
* API Review feedback
* RequestFailedException includes error information
* Fixed test collateral
* Added changelog entry for new core version; Added tests to verify response message contains all expected fields
* Created extendableenumeration class
* Convert attestation to use extendable enumeration; added test for extendable enumerations
Co-authored-by: Casey Carter <cartec69@gmail.com>
* Set WinHTTP_OPTION_CLIENT_CERT_CONTEXT to enable connections to attestation service
* Set serviceDirectory from environment variables
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* Removing the two param RFE ctor, there should be no callers
* Remove the two param RFE ctor from the source file.
* Fix-up unit test and add a changelog entry.
* Remove test that uses the removed ctor.
It all started with UWP. The [docs](https://docs.microsoft.com/en-us/cpp/cppcx/crt-functions-not-supported-in-universal-windows-platform-apps?view=msvc-170) say: "`Environment variables are not available to UWP apps.`". And it truly won't work, I tried: linker error, the function is simply not present.
So, for a year or so, we were `ifdef`ing everything enivoronment-related: console logger, environment credential, managed identity credential.
And then just recently we wanted to enable our CI for UWP, including tests and samples. And it required to do more ifdefs (in vcpkg, we don't build samples or tests, so that problem did not exist).
It just became more messy. Especially in samples - you can see how we would disable warning with `#pragma warning(disable : 4996)` or defining `_CRT_SECURE_NO_WARNINGS` already, but now came UWP, so we would have to add comment that `getenv()` is not available and make the sample compilation to either fail with clear message, or throw an exception. Plus we would have to detect that we are being compiled on UWP, which also adds visual clutter for reader. You can see how such an irrelevant (for a sample) thing as `getenv` was consuming more and more lines of sample code and reader's attention.
But then! I read docs on more APIs for UWP. And I noticed that on .NET you can read environment variables. So I went and checked Win32 API docs for [GetEnvironmentVariable()](https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getenvironmentvariable) - it says: "`Minimum supported client: ... UWP apps`".
**GetEnvironmentVariable() works on UWP!**
And so does `SetEnvironmentVariable()` (our tests use it, which means we can make all of them work and execute for UWP).
That's good news, but now it would probably be more code: it usually takes more lines to invoke WinAPI, it is no more an one-liner to call `getenv()/setenv()`. So, I encapsulated that into `Azure::Core::_internal::Environment::GetVariable()` and `SetVariable()`. You can see how much less ifdefs is in our code now. Not to mention it works on UWP!
Per team request, that API is SDK-internal. Samples use their own mini-helper project, `get-env-helper` that makes is so that `getenv()` works naturally on Linux and macOS, compiles without warnings and works on Win32, and compiles and works on UWP (using `GetEnvironmentStringsA()`)
If it was for me, I would just make `Azure::Core::Environment::GetVariable()` public and simplify even further, I think it would be beneficial for sample readers (you can see that extra `get-env-helper` stuff adds just a little more visual clutter, compared to nothing). But I can see reasons against that, why team did not want to do it.
* Generate map files in build
* Add .map file artifact publishing
* Add Xlinker to spelling exceptions
* Remove PublishMapFiles from clang builds
* Generate the map file artifact name
* CXX_COMPILER_ID and some logging for Clang which might be linking using the GNU linker by default
* More logging
* Move logging out of conditional
* Logging up high, use OS to determine which link flags to set
* Use linker options specific to AppleClang's context, publish map files for all platforms
* Enable no-rtti
* Apply suggestions from code review
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* pass target
* rename
* rename
* fix for installed header
* update
* compile with tests
* add unit test for CI
* rename for each package
* wording updates
* renames
* rename
* update name
* fix for testing context pre-condition
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Move the SHA256, 384, and 512 Hash implementations to be internal.
* Update changelog and add back missing file.
* Rename SHA256 and others to Sha256Hash and update header name.
* Fix up path in CMakeList by removing quotes.
* Rename the sha.cpp source file to match header.
* Move Sha256Hash and other Hash algorithm types from KeyVault to
Azure::Core.
* Reorder src file in cmakelist to be alpha order just to reset CI
* Revert "Reorder src file in cmakelist to be alpha order just to reset CI"
This reverts commit 6729cf311af76bb8388738cc519ea40092bc362c.
* first UT
* formatting
* unused error
* putenv
* some refactoring
* formatting
* casting
* again
* Update sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* some refactoring
* more tests
* format
* no env test
* put back missing empty line
* Update sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* PR comments
* fix signed/unsigned mismatch that causes ci build to fail
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* update docs from classes
* remove more link from classes part II
* http docs
* Update sdk/core/azure-core/inc/azure/core/http/http.hpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Update cmake-modules/AzureDoxygen.cmake
* doc updates
* update RFC
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Add argument validation to public APIs.
* Add exception to spell check.
* Revert "Add exception to spell check."
This reverts commit be54b614cc1427ddb2f154f5927f4e612a4a1e28.
* Turn invalid arg excetion to a precondition assert for bodystream read.
* User assert in more places within body_stream.
* Update valiation for hashing and bodystream and update tests.
* Update precondition test for size_t and add null ptr check
* Fix clang formatting.
* Update changelog and fix up the message for size_t validation in hash.
* Address PR feedback.
* More PR feedback.
* Remove unnecessary comment from test.
* Fix clang format.
* Use size_t for buffers representing data in memory rather than int64_t.
* add a cast from size_t to int64_t
* Address feedback - OnRead return size_t.
* Change Read and ReadToCount to return size_t instead of int64_t.
* Update curl usage and ReadFromSocket.
* Missed one signature.
* Update changelog.
* Update transport layer to use the right size_t size.
* Fix curl use of MBS.
* Cast to size_t since that's all memory stream supprts.
* Add static casts to size_t as temporary workarounds.
* update storage tests.
* More test fixes.
