Commit Graph

208 Commits

Author SHA1 Message Date
Azure SDK Bot
642c311676
Use single quotes for matrix generator command line arguments (#2028)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-04-05 12:53:33 -04:00
Azure SDK Bot
0c1ec5c69e
Sync eng/common directory with azure-sdk-tools for PR 1525 (#2015)
* Use SubscriptionId throughout TestResources

Fixes #1454

* Resolve PR feedback

* Default DeleteAfterHours to 48 for SDK team

Also makes a few other adjustments for subscriptions, like restoring the previous one if available and another was specified.

* Resolve PR feedback

* Change deployment mode to Complete

Also fixes an issue where if the user opted not to deploy to the same resource group, the script would continue execution anyway.

* Use consistent aka links to satisfy link checker

Only need it for the new Update-TestResources.ps1 script, but I wanted them to look consistent.

Co-authored-by: Heath Stewart <heaths@microsoft.com>
2021-04-01 09:39:24 -07:00
Azure SDK Bot
fcbaf7301c
Sync eng/common directory with azure-sdk-tools repository (#2014) 2021-03-31 11:19:45 -07:00
Azure SDK Bot
0990a8599e
Add DependsOn parameter to matrix job generation template (#2001)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-03-30 11:25:11 -07:00
Azure SDK Bot
b4110380f0
Sync eng/common directory with azure-sdk-tools for PR 1477 (#1981)
* Checked in the changes directly.

* Address feedback and remove the check of set-default-branch

* Fixed base repo branch

* Update git-branch-push.ps1

* Fixed the docs-metadata-release

* Change the typo

* Update eng/common/scripts/git-branch-push.ps1

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Keep origin format

* Update git-branch-push.ps1

* Keep fixing the typo

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-03-26 17:30:54 -07:00
Azure SDK Bot
24f44838a8
Sync eng/common directory with azure-sdk-tools for PR 1521 (#1982)
* Fix issue where 2d index arrays with length 1 get flattened by powershell

* Pass NonSparseParameters to imported matrix generation

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-03-26 12:52:31 -07:00
Azure SDK Bot
8d435df2d3
Support default branch for the workflow. Part 1 (#1979)
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
2021-03-26 10:28:32 -07:00
Azure SDK Bot
f1688491d9
Sync eng/common directory with azure-sdk-tools for PR 1508 (#1956)
* Skip API create step when running from feature branch with non GA version
2021-03-26 01:40:47 -07:00
Azure SDK Bot
ea57783e05
Sync eng/common directory with azure-sdk-tools for PR 1478 (#1978)
* actually pass the _content_ of the reviewers or teamreviewers variable within create-pull-request.yml, update logic in Set-GitHubParameter
2021-03-26 01:25:26 +00:00
Azure SDK Bot
c0769b8e33
Sync eng/common directory with azure-sdk-tools for PR 1517 (#1977)
* Add chagelogpath to Update-ChangeLog.ps1

* Make PackageName and ServiceDirectory not mandatory, test ChangelogPath

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-25 15:52:00 -07:00
Azure SDK Bot
b6c354f435
Sync eng/common directory with azure-sdk-tools for PR 1514 (#1960)
* Handle null values when generating display names

* Fix issue processing matrices where the base matrix is only an import

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-03-23 12:51:00 -07:00
Azure SDK Bot
eb1177ea3a
Add ReleaseTrackingOnly option to Prepare-Release (#1958) 2021-03-22 20:21:13 -07:00
Azure SDK Bot
47d7a91c0c
Ensure version is sorted as semVer (#1948)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-19 14:36:15 -07:00
Azure SDK Bot
d577d25041
Sync eng/common directory with azure-sdk-tools for PR 1489 (#1928)
* Add draft to Submit-PullRequest.ps1

* Add -Draft to create-pull-request.yml

* Add documentation

* Rename: Draft[Pr] -> OpenAsDraft

* Update docs

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-03-18 14:50:46 -07:00
Azure SDK Bot
e464f8b01e
Sync eng/common directory with azure-sdk-tools for PR 1498 (#1924)
* Fix null check against matrix parameter array

* add negative test cases

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
2021-03-18 13:34:30 -04:00
Azure SDK Bot
ca1692e375
Sync eng/common directory with azure-sdk-tools for PR 1463 (#1919)
* Add 'replace' support. Improve handling of dynamic parameter types.

* Support display name import and overrides

* Support regex capture groups for replace. Force fully matching regex.

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-03-16 16:46:41 -07:00
Azure SDK Bot
6e19575491
Revert to Checking only ci.yml (#1918)
Pull only artifacts from `ci.yml` to resolve issue with conflicting package names.

Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
2021-03-16 14:53:03 -07:00
Azure SDK Bot
d08bebfb6a
Sync eng/common directory with azure-sdk-tools for PR 1418 (#1759)
* Update Package Properties Logic, make prepare release require only 1 argument, make rerun of Get-PkgProperties in Update-Changelog not required

* Remove ServiceDirectory parameter from PrepareRelease.ps1

* changes to argument names

* pass service directory to Get-AllPackageInfoFromRepo

* Remove changes in Update-ChangeLog.ps1

* updates to Package-Properties.ps1

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
2021-03-15 23:23:26 -07:00
Azure SDK Bot
23c1d891b7
Sync eng/common directory with azure-sdk-tools for PR 1490 (#1905)
* Create a publish-artifact.yml template step within eng/common. This template utilizes PublishPipelineArtifactV1 to upload your artifact only in the case where steps up till the invocation are succeeded(). Otherwise, the artifacts will be uploaded to an alternate artifact name.
2021-03-15 12:08:13 -07:00
Azure SDK Bot
d7924ce12f
Address PR feedback (#1826)
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
2021-03-15 10:04:22 -07:00
Azure SDK Bot
6a8aff701c
Fix bug in Changelog URL path using packageDirectoryName (#1878)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-11 16:50:56 -08:00
Azure SDK Bot
8dcea0f47f
Sort changelogs by date then version (#1832)
Fixes #1389

Co-authored-by: Heath Stewart <heaths@microsoft.com>
2021-03-10 11:57:49 -08:00
Azure SDK Bot
7a93457f42
Use latest pipeline generator. (#1817)
Co-authored-by: Mitch Denny <midenn@microsoft.com>
2021-03-09 15:43:04 -08:00
Azure SDK Bot
37454b68ef
Sync eng/common directory with azure-sdk-tools for PR 1452 (#1814)
* Use sparse checkout for generate matrix job

* Add repository parameter

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-03-08 18:07:54 -08:00
Azure SDK Bot
3b88c7bb83
move SetTestPipeline into its own template (#1799)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-05 17:10:40 -08:00
Azure SDK Bot
b96f42481c
Fix logic in SetTestPipelineVersionInEngCommon (#1794)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-05 13:49:38 -08:00
Azure SDK Bot
64d18ea182
Fix bug where imported matrix parameter duplicates are not overrided (#1790)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-03-05 12:59:49 -08:00
Azure SDK Bot
f3e98ffb47
Sync eng/common directory with azure-sdk-tools for PR 1448 (#1774)
* Added more logging to API view create

* Updated logs with arch board rescue email address

* Fix as per review comments

* Update logging to show API URL

Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
2021-03-05 06:46:59 -08:00
Azure SDK Bot
2ffb694cdd
Enable APIView status check (#1781)
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
2021-03-05 03:11:34 -08:00
Azure SDK Bot
d8b532af57
Fix PackageName typo (#1782)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-04 20:38:17 -08:00
Azure SDK Bot
a475980de6
Move SetTestPipelineVersion.ps1 to eng/common (#1780)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-04 18:42:45 -08:00
Azure SDK Bot
d782c99777
Fix LanguageShort typo (#1768)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-03-03 12:24:09 -08:00
Azure SDK Bot
02622fff74
Update Prepare-Release script (#1757)
- Remove BuildType parameter as we can default it from package properties
- Stop passing BuildType and GroupId and instead defaul them from package properties
- Enable StrictMode to help identify potential errors
- Start passing sdktype and isnewsdk properties to devops script
- Sync latest changes with devops work item to fix a couple bugs

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
2021-02-26 18:46:42 -08:00
Azure SDK Bot
824853d948
Sync eng/common directory with azure-sdk-tools for PR 1421 (#1720)
* Add common tools for spell check

* Updates from further iteration

* Review feedback: Add check for git as well

* Review feedback * Use common approach to resolving base branch name * Eliminate default base branch "master" as this will be changed later, providing no default and using a mandatory parameter means a dev must provide the value * Check for existence of $CspellConfigPath * No need to Set-Location if run from the root of the repo (most common scenario) * -join

* Review feedback: Rename TargetRef -> TargetBranch, add SourceBranch, Add reference to spelling docs, exit 0, Rename to check-spelling-in-changed-files.ps1,

* Review feedback: Remove ValidateNotNullOrEmpty (we do more definitive validation farther down that will also catch these errors), Update comments and script name

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-02-22 22:16:09 -08:00
Azure SDK Bot
7e22da08b9
Restore pipeline output variable for Agent OS name (#1709)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-02-22 16:47:08 -05:00
Azure SDK Bot
b8af41f79a
Update pipeline generator version to include weekly convention name fix (#1710)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-02-19 15:27:28 -08:00
Azure SDK Bot
5a1fedd0d5
Sync eng/common directory with azure-sdk-tools for PR 1429 (#1705)
* Add job matrix generation scripts

* Add working job matrix example pipeline and common matrix generation pipeline.

* Update job matrix tests path

* Parameterize matrix generation job path

* Add global variable to override nuget security checks to sample matrix pipeline

* Update readme matrix pipeline example to match sample file

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-02-19 14:45:31 -08:00
Azure SDK Bot
5e97c8f67f
Sync eng/common directory with azure-sdk-tools for PR 1425 (#1698)
* Trim off the target branch

* Update eng/common/scripts/get-markdown-files-from-changed-files.ps1

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Update get-markdown-files-from-changed-files.ps1

* Update get-markdown-files-from-changed-files.ps1

* Trim the slash

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-02-19 12:02:01 -08:00
Azure SDK Bot
6e4306dc93
Only run eng/common check when target branch is master (#1688)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-19 11:06:36 -08:00
Azure SDK Bot
ebe169bc96
Sync eng/common directory with azure-sdk-tools for PR 1396 (#1695)
* Change other version to all versions

* Exclude the packages which already show up in latest GA and preview

* Update main.js

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
2021-02-18 11:55:16 -08:00
Azure SDK Bot
f929894274
Sync eng/common directory with azure-sdk-tools for PR 1374 (#1686)
* Create package property file using artifact name

* Add option to pass config file dir

* Set default config file directory to avoid script execution failure

Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
2021-02-16 11:57:56 -08:00
Azure SDK Bot
74bfafcb52
Sync eng/common directory with azure-sdk-tools for PR 1371 (#1634)
* Rework verify agent OS step.

* Address feedback

* Justing string matching instead.

* ! instead of -not

Co-authored-by: Mitch Denny <midenn@microsoft.com>
2021-02-14 15:56:25 -08:00
Azure SDK Bot
ab0a92ce62
Sync eng/common directory with azure-sdk-tools for PR 1408 (#1683)
* Improve TestResources docs and logging

Resolves #1388
Resolves #1407

Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs.

* Add ADP test sub to look-up

Co-authored-by: Heath Stewart <heaths@microsoft.com>
2021-02-12 19:08:11 -08:00
Azure SDK Bot
d76cdf4c6d
Allow logging into specific subscription (#1681)
Resolves #1404

Co-authored-by: Heath Stewart <heaths@microsoft.com>
2021-02-12 12:29:16 -08:00
Azure SDK Bot
65453834ae
Update eng-common-workflow-enforcer (#1674)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-12 11:40:11 -08:00
Azure SDK Bot
9e0494674f
Change script parameters to boolean (#1672)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-11 13:43:16 -08:00
Azure SDK Bot
e99c6df201
Enable passing devops pat for work item scripts (#1670)
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
2021-02-11 11:12:18 -08:00
Azure SDK Bot
3282a05d49
Sync eng/common directory with azure-sdk-tools for PR 1358 (#1669)
* Extend Get-GitHubPullRequest to return only files

* Add check to prevent eng/common changes that are not proper syncs

* Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-02-11 10:12:13 -08:00
Azure SDK Bot
2741ad4762
Sync eng/common directory with azure-sdk-tools for PR 1303 (#1667)
* Add PrepareRelease Script

* Update Package-Properties.ps1

* Update Collect-ChangeLog Script

* Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1

* Update GeneralReleaseNotesParser.ps1 script

* Change GeneralReleaseNotesParser logic

* Change GeneralReleaseNotesParser.ps1 logic

* Remoce GeneralReleaseNotesParsercopy

* Update collect changelog and generalreleasenotes parser logic

* Refine CollectChangelog Logic

* Add logic for filtering collected changelog

* Add Filter-ReleaseHighlights function

* Update General ReleasNotes Logic

* Delete GeneralReleaseNotesLogic.ps1

* Update Collect ChangeLogLogic

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-10 18:43:01 -08:00
Azure SDK Bot
66e66aa83b
Sync eng/common directory with azure-sdk-tools for PR 1393 (#1666)
* Hide the package which set to true instead of putting to Other page

* Hide the package not showing in csv

* Added logging message

* fix the variable

* leave an extra space

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-02-10 13:36:40 -08:00