* Prepare attestation for release
* removed references to RetrieveResponseValidationCollateral from docs
* Added C++ SDK team as owners of attestation SDK
* Added Ahmad from attestation team to attestation owners
* Removed dead API; switched attestation back to beta-3
* Moved samples around to meet new recommendations; added a couple of additional tests.
* Reworked attestation to include RetrieveAttestationValidationCollateral
* Attestation sample readme updates
* TPM doesn't need to retrieve response validation collateral
* Added cautionary warning about the dangers of overriding the TearDown method from inside a test case
* Added attestation team members to codeowners for attestation SDK
* Remove CODEOWNERS from cspell checks
* Don't hold a lock across retrieving the signers over the network
* Updated snippets in readme; clang-format
* Fabric Bot Configuration
The focus of these changes is to add the Fabric Bot rules into the repository.
* Apply suggestions from code review
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Trying to reduce the noise to signal ratio and manage GitHub notifications to when I am explicitly tagged for relevant reviews and conversations, rather than during day-to-day keyvault code churn and features.
It is generally useful for PR authors to go through their own PR first to make sure that commonly occurring feedback and issues have already been addressed. This checklist should help remind contributors what to look out for and is a living doc that we can modify and add to.
I ask these questions to myself before submitting a PR, when looking through my changes in the "pre-PR-submit-view".
Where possible leverage linter tools and CI gates to help address some of these. For example, for spell-check, here are some solutions to make things easier within the developer inner-loop:
- VS Code extension: [Code Spell Checker](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker)
- VS Code extension: [Markdown linter](https://github.com/DavidAnson/vscode-markdownlint)
- Browser extension: [Site Spell](https://www.site-spell.com/)
