This was broken by a035ee5f94, which
accidentally constructed the IMDS URL with a double slash at the start
of the path. This is not properly routed on the server side, leading to
a 404 error with some very misleading XML.
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
* Identity: 'AZURE_TOKEN_CREDENTIALS' env var support for specific credential names
* No need to use index-based loop at that place
* Clang-format
* Require 'Credential' suffix for env var values
* Update sdk/identity/azure-identity/CHANGELOG.md
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Azure Core and Identity July GA Releases
* Add Identity to the release
* Undo change to FolderList.cmake (chicken vs egg problem; we'll have to update after the release)
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Increment package version after release of azure-storage-queues
* Changed QueueProperties.ApproximateMessagesCount from int to long (#6584)
* Storage/STG99 Added ShareSnapshotNotFound in ShareErrorCode (#6612)
* Share SnapshotNotFound error code support
* add test record
* Storage/STG99 Made error message for invalid x-ms-version more user-friendly (#6613)
* add invalid version erorr message support
* Update find logic
* Stg99/Add test records and update change logs (#6620)
* Update test records and change logs
* update change log
* Identity: IMDS fail-fast and Cred order change in DAC (and Core support)
* Mac fix and cspell update
* Update unit test and clang-format
* Temporarily update samples to use AzCliCred until recordings are re-recorded
* Revert samples back to use DAC
* Remove SAS auth from Tables template
* Clang-format
* Add support for 'AZURE_POD_IDENTITY_AUTHORITY_HOST', override it for running samples in CI
* Add unit test for AZURE_POD_IDENTITY_AUTHORITY_HOST
* "in milliseconds"
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* PR Feedback
* Named constant + comment
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Update vcpkg baseline
* Make code to compile with either newer or older version of opentelemetry-cpp
* Clang-format
* Suppress otel warnings in stress test code
* Update CI to update vcpkg cache if the run is PR-initiated
* Turn SSL caching off by default
* Make code to compile with either newer or older version of opentelemetry-cpp
* Clang-format
* Integrate the exact copy of #6581 - to make sure we're testing the same change with libcurl >= 8.12, and also make future merging easier
* Update cspell
* Move feature to bugfix
* Update vcpkg.yml
* Copy #6582 to verify against the latest libcurl
* Undo unnecessary changes
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Fix Windows error for failing curl SSL cache
* Fix unused parameter warning in win_http_transport.cpp, as in #6579
* Update changelog, cspell, and conditional init m_sslShareHandle
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add SSL caching share for curl
* Use correct destructor for CURLSH RAII
* Unit tests passing locally
* Add curloptions test for coverage and fix clangformat errors
* whitespace reverts
* Fix clang format errors
* Address PR comments
* Update changelog and CI line coverage target
* Update Changelog and set curl options test to disable ssl caching for validating non-default codepath
* Update sdk/core/azure-core/CHANGELOG.md
* Update CHANGELOG.md
* Update cspell.json
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* get set acl oauth (#6405)
* Storage STG98/Added support for x-ms-file-request-intent for blob copy APIs (#6406)
* Source File Copy Support
* Storage STG98/NFS 2 (#6404)
* feature
* add test record
* Update blob sas new string to sign (#6511)
* Identity: update Troubleshooting.md with all the credentials
* </li></ul>
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Temporarily disable CheckFailedCrlValidation test to unblock CI
* Update branch coverage
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-security-keyvault-keys
* Increment package version after release of azure-security-keyvault-secrets
* Increment package version after release of azure-security-keyvault-certificates
* generate code and build the generated code
* client
* update name
* put back things
* work in progress for get
* get and get version
* das
* issuer ops
* set/get/delete contacts
* backup restore
* Get /update policy
* purge
* get deleted
* Update props
* Merge cert
* import cert
* Create
* Start delete
* Recover
* Delete/Cacel op
* GetCertsProps
* Get versions
* get deleted certs
* getissuers
* some cleanup and tests all working
* samples
* test record
* PR build
* more PR stuffs
* PR update part i lost count
* clang
* Update sdk/keyvault/azure-security-keyvault-certificates/samples/certificate-basic-operations/certificate_basic_operations.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-certificates/samples/certificate-get-certificates/certificate_get_certificates.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-certificates/samples/certificate-import-certificate/certificate_import_certificate.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-certificates/test/ut/certificate_client_base_test.hpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-certificates/test/ut/certificate_client_test.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* comments
* explicitly turn off
* friend comments
* clang
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Add support for building with ICU 75.1 or later
We use ICU via libxml2 implicitly. ICU 75.1 or later require C++17 for
its C++ API:
https://github.com/unicode-org/icu/releases/tag/release-75-1
> C++ code now requires C++17
But we use C++17. So `#include <libxml/xmlreader.h>` with ICU 75.1 or
later causes an error:
[1/177] Building CXX object sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o
FAILED: sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o
/bin/c++ -DAZ_RTTI -DBUILD_CURL_HTTP_TRANSPORT_ADAPTER -D_azure_BUILDING_SDK
-Isdk/storage/azure-storage-common/inc -Isdk/core/azure-core/inc
-isystem /usr/include/libxml2 -g -std=gnu++14 -fno-operator-names
-Wold-style-cast -Wall -Wextra -pedantic -Werror -MD
-MT sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o
-MF sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o.d
-o sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o
-c sdk/storage/azure-storage-common/src/xml_wrapper.cpp
In file included from /usr/include/unicode/uenum.h:25,
from /usr/include/unicode/ucnv.h:52,
from /usr/include/libxml2/libxml/encoding.h:31,
from /usr/include/libxml2/libxml/parser.h:812,
from /usr/include/libxml2/libxml/globals.h:18,
from /usr/include/libxml2/libxml/threads.h:35,
from /usr/include/libxml2/libxml/xmlmemory.h:218,
from /usr/include/libxml2/libxml/tree.h:1307,
from /usr/include/libxml2/libxml/xmlreader.h:14,
from sdk/storage/azure-storage-common/src/xml_wrapper.cpp:23:
/usr/include/unicode/localpointer.h:561:26: error: 'auto' parameter not permitted in this context
561 | template <typename Type, auto closeFunction>
| ^~~~
/usr/include/unicode/localpointer.h:573:76: error: template argument 2 is invalid
573 | explicit LocalOpenPointer(std::unique_ptr<Type, decltype(closeFunction)> &&p)
| ^
/usr/include/unicode/localpointer.h:583:78: error: template argument 2 is invalid
583 | LocalOpenPointer &operator=(std::unique_ptr<Type, decltype(closeFunction)> &&p) {
| ^
/usr/include/unicode/localpointer.h:599:59: error: template argument 2 is invalid
599 | operator std::unique_ptr<Type, decltype(closeFunction)> () && {
| ^
/usr/include/unicode/uenum.h:69:1: note: invalid template non-type parameter
69 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUEnumerationPointer, UEnumeration, uenum_close);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/unicode/ucnv.h:597:1: note: invalid template non-type parameter
597 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUConverterPointer, UConverter, ucnv_close);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
We don't need ICU C++ API. So we can avoid this error by disabling ICU
C++ API by defining `U_SHOW_CPLUSPLUS_API` as `0`.
* Update CHANGELOG
* Update Identity root README to align with the common format
* Update vcpkg link identifier in README
* Remove vcpkg installation instructions from README
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
