# Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/main/CONTRIBUTING.md#pull-requests).
- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
- [x] PR is single purpose
- [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [] Any breaking changes?
* add support for non public scope for secret client credential
* improve function comments
* update tests with good url
* update secret url tests
* update logic to no-throw
* use class
* Update sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* format
* fix
* remove default scope
* move patch out of Core to use package-per-client patch
* update includes
* Update sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* update patch
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* playback tests
* two running tests
* more tests and some redaction
* formatting
* formatting
* fix bb and remove unused includes
* macos
* annoying issues
* offline client
* format
* pr comment
* reset the env to original after the client is gone.
* oops
* testing
* formats
* remove default resource for secrets, not needed
* code coverage
* build issue
* first set of changes
* another set
* add new constructor
* format files, remove pedantinc ;
* factory
* format
* expect_death not behaving as expected
* ignore result of function
* changelog
* Add g++5 to CI legs
* use inline config for g++ 5
* update flag
* set default values for variables
* fix format
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* storage 12.1.0 release
* a
* Apply suggestions from code review
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update changelog for Clang 11 comunity contribution
* Move to correct place, arrange in correct order
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
